Skip to content

Conversation

@pgherveou
Copy link
Contributor

@pgherveou pgherveou commented May 12, 2025

  • Break down eth-rpc client storage and runtime API into separate files
  • Make debug_trace methods Return a composite Trace enum so we can introduce other trace types (in follow up PR)
  • Fix eth_getStorageAt to use BigEndian for key encoding

companion evm-test-suite PR paritytech/evm-test-suite#93

Fix paritytech/contract-issues#67

@pgherveou pgherveou marked this pull request as ready for review May 12, 2025 16:37
@pgherveou
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump major

@pgherveou pgherveou added the T7-smart_contracts This PR/Issue is related to smart contracts. label May 12, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/14980457928
Failed job name: test-linux-stable-no-try-runtime

@pgherveou pgherveou requested review from a team as code owners May 13, 2025 09:07
Comment on lines +11 to +16
- name: asset-hub-westend-runtime
bump: major
- name: pallet-revive-eth-rpc
bump: major
- name: pallet-revive
bump: major
Copy link
Member

@athei athei May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major bumps cannot be backportet. Did you intend to get this into 2503?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked is as major cause it makes breaking change to the runtime API

@pgherveou pgherveou added the A4-backport-stable2503 Pull request must be backported to the stable2503 release branch label May 15, 2025
@pgherveou pgherveou enabled auto-merge May 15, 2025 10:04
@pgherveou pgherveou added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@pgherveou pgherveou added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@athei athei added this pull request to the merge queue May 15, 2025
Merged via the queue into master with commit d99bafc May 15, 2025
243 of 249 checks passed
@athei athei deleted the pg/revive-dev-node-0 branch May 15, 2025 13:14
@paritytech-release-backport-bot

Created backport PR for stable2503:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-8495-to-stable2503
git worktree add --checkout .worktree/backport-8495-to-stable2503 backport-8495-to-stable2503
cd .worktree/backport-8495-to-stable2503
git reset --hard HEAD^
git cherry-pick -x d99bafc738266f97bd03807909772b4471e56ce4
git push --force-with-lease

pgherveou added a commit that referenced this pull request May 15, 2025
- Break down eth-rpc client storage and runtime API into separate files
- Make debug_trace methods Return a composite Trace enum so we can
introduce other trace types (in follow up PR)
- Fix eth_getStorageAt to use BigEndian for key encoding

companion evm-test-suite PR
paritytech/evm-test-suite#93

Fix paritytech/contract-issues#67

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit d99bafc)
pgherveou added a commit that referenced this pull request May 15, 2025
Backport #8495 into `stable2503` from pgherveou.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: PG Herveou <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alstjd0921 pushed a commit to bifrost-platform/polkadot-sdk that referenced this pull request Aug 14, 2025
Backport paritytech#8495 into `stable2503` from pgherveou.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: PG Herveou <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
- Break down eth-rpc client storage and runtime API into separate files
- Make debug_trace methods Return a composite Trace enum so we can
introduce other trace types (in follow up PR)
- Fix eth_getStorageAt to use BigEndian for key encoding

companion evm-test-suite PR
paritytech/evm-test-suite#93

Fix paritytech/contract-issues#67

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2503 Pull request must be backported to the stable2503 release branch T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make debug_trace methods Return a composite Trace

5 participants