-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[pallet-revive] tracing prepare support for future tracing APIS #8495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cmd prdoc --audience runtime_dev --bump major |
…time_dev --bump major'
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
| - name: asset-hub-westend-runtime | ||
| bump: major | ||
| - name: pallet-revive-eth-rpc | ||
| bump: major | ||
| - name: pallet-revive | ||
| bump: major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major bumps cannot be backportet. Did you intend to get this into 2503?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked is as major cause it makes breaking change to the runtime API
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-8495-to-stable2503
git worktree add --checkout .worktree/backport-8495-to-stable2503 backport-8495-to-stable2503
cd .worktree/backport-8495-to-stable2503
git reset --hard HEAD^
git cherry-pick -x d99bafc738266f97bd03807909772b4471e56ce4
git push --force-with-lease |
- Break down eth-rpc client storage and runtime API into separate files - Make debug_trace methods Return a composite Trace enum so we can introduce other trace types (in follow up PR) - Fix eth_getStorageAt to use BigEndian for key encoding companion evm-test-suite PR paritytech/evm-test-suite#93 Fix paritytech/contract-issues#67 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit d99bafc)
Backport #8495 into `stable2503` from pgherveou. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: PG Herveou <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Backport paritytech#8495 into `stable2503` from pgherveou. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: PG Herveou <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- Break down eth-rpc client storage and runtime API into separate files - Make debug_trace methods Return a composite Trace enum so we can introduce other trace types (in follow up PR) - Fix eth_getStorageAt to use BigEndian for key encoding companion evm-test-suite PR paritytech/evm-test-suite#93 Fix paritytech/contract-issues#67 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
companion evm-test-suite PR paritytech/evm-test-suite#93
Fix paritytech/contract-issues#67