Remove yamux_window_size from network config#7014
Merged
bkchr merged 4 commits intoparitytech:masterfrom Feb 17, 2025
Merged
Conversation
bkchr
approved these changes
Dec 30, 2024
Member
|
/cmd prdoc --bump major --audience node_dev |
lexnv
approved these changes
Feb 17, 2025
Contributor
lexnv
left a comment
lexnv
left a comment
There was a problem hiding this comment.
This looks good to me! Currently, litep2p uses yamux_window_size config. However, since the litep2p is not enabled by default, and we'll come soon with a release that removes the window size, we can safely merge this PR. Thanks for contributing 🙏
Merged
via the queue into
paritytech:master
with commit Feb 17, 2025
6b6dae8
208 of 217 checks passed
clangenb
pushed a commit
to clangenb/polkadot-sdk
that referenced
this pull request
Feb 19, 2025
# Description resolve paritytech#6468 # Checklist * [x] My PR includes a detailed description as outlined in the "Description" and its two subsections above. * [x] My PR follows the [labeling requirements]( https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process ) of this project (at minimum one label for `T` required) * External contributors: ask maintainers to put the right label on your PR. * [x] I have made corresponding changes to the documentation (if applicable) * [x] I have added tests that prove my fix is effective or that my feature works (if applicable) --------- Co-authored-by: command-bot <>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolve #6468
Checklist
Trequired)