[pallet-revive] implement the gas limit API #6926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyrill Leutwiler <[email protected]>
xermicus
added
R0-no-crate-publish-required
Member
Author
|
bot fmt |
|
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7927502 was started for your command Comment |
|
@xermicus Command |
Member
Author
|
/cmd prdoc --audience runtime_dev --bump major |
Member
Author
|
/cmd bench --runtime dev --pallet pallet_revive |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
athei
reviewed
Dec 17, 2024
substrate/frame/revive/src/limits.rs
Outdated
|
|
||
| /// Maximum size of events (including topics) and storage values. | ||
| pub const PAYLOAD_BYTES: u32 = 512; | ||
| pub const PAYLOAD_BYTES: u32 = 384; |
Member
There was a problem hiding this comment.
This seems unrelated. Why was this changed?
Member
Author
There was a problem hiding this comment.
Should have pointed out. The integrity checks fail with 2 seconds ref_time and payload bytes of 512 because the max_events_size < storage_size_limit fails. I lowered this because I think we want 2s ref_time per block.
If there is a better solution or the integrity check is incorrect we should fix that, I'm open.
Member
There was a problem hiding this comment.
On a parachain you only have 0.5s of execution time. With async backing its 1 second I think. But probably better to lower this ratio in order to future proof.
Member
There was a problem hiding this comment.
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
pgherveou
approved these changes
Dec 17, 2024
Comment on lines
375
to
378
| pub BlockWeights: frame_system::limits::BlockWeights = | ||
| frame_system::limits::BlockWeights::simple_max( | ||
| Weight::from_parts(2u64 * WEIGHT_REF_TIME_PER_SECOND, u64::MAX), | ||
| Weight::from_parts(2 * WEIGHT_REF_TIME_PER_SECOND, u64::MAX), | ||
| ); |
Contributor
There was a problem hiding this comment.
can't we delete this and just use the default
https://github.com/paritytech/polkadot-sdk/blob/pg/fix-gas-encoding/substrate/frame/system/src/limits.rs?plain=1#L208
Member
Author
There was a problem hiding this comment.
Yeah I think we should have this consistent. But I think it should be the maximum we aim to support. What would that be?
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Bumped it a bit further to 448, approaching the 2s limit closely.
athei
approved these changes
Dec 18, 2024
Member
Author
|
/cmd bench --runtime dev --pallet pallet_revive |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Contributor
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
4 tasks
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
This PR implements the gas limit API, returning the maximum ref_time per block. Solidity contracts only know a single weight dimension and can use this method to get the block ref_time limit. --------- Signed-off-by: Cyrill Leutwiler <[email protected]> Signed-off-by: xermicus <[email protected]> Co-authored-by: command-bot <>
7 tasks
This was referenced Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the gas limit API, returning the maximum ref_time per block. Solidity contracts only know a single weight dimension and can use this method to get the block ref_time limit.