[AHM] Poke deposits: Indices pallet

[UtkarshBhardwaj007]

Description

• This PR adds a new extrinsic reconsider to pallet-indices. This extrinsic will be used to re-adjust the deposits made in the pallet.
• Part of Re-consideration poke for Deposits  #5591

Review Notes

• Added a new extrinsic reconsider in pallet-indices.
• Added a new event DepositReconsidered to be emitted upon a successful call of the extrinsic.
• Although the immediate use of the extrinsic will be to give back some of the deposit after the AH-migration, the extrinsic is written such that it can work if the deposit decreases or increases (both).
• The call to the extrinsic would be free if an actual adjustment is made to the deposit and paid otherwise.
• Added tests to test all scenarios.
• Added a benchmark to test the "worst case" (maximum compute) flow of the extrinsic which is when the deposit amount is updated to a new value.

TO-DOs

• Run CI cmd bot to benchmark

[kianenigma]

Mainly unsure about Permanent, otherwise looks good.

[UtkarshBhardwaj007]

Mainly unsure about Permanent, otherwise looks good.

From what I understand from the code, the freeze extrinsic slashes the deposit here before marking an index as permanent meaning there is no deposit left to reconsider. @kianenigma

[ggwpez]

LGTM

[UtkarshBhardwaj007]

/cmd fmt

[UtkarshBhardwaj007]

/cmd fmt

[UtkarshBhardwaj007]

/cmd bench --pallet pallet_indices

[github-actions]

Command "bench --pallet pallet_indices" has started 🚀 See logs here

[github-actions]

Command "bench --pallet pallet_indices" has finished ✅ See logs here

Subweight results:

File	Extrinsic	Old	New	Change [%]
cumulus/pallets/collator-selection/src/weights.rs	leave_intent	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	new_session	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	register_as_candidate	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	set_invulnerables	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	take_candidate_slot	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_preimage.rs	ensure_updated	-	-	ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
polkadot/runtime/westend/src/weights/pallet_preimage.rs	ensure_updated	-	-	ERROR
substrate/frame/election-provider-support/src/weights.rs	phragmen	-	-	ERROR
substrate/frame/election-provider-support/src/weights.rs	phragmms	-	-	ERROR
substrate/frame/utility/src/weights.rs	dispatch_as_fallible	-	-	ERROR
substrate/frame/indices/src/weights.rs	free	153.54us	145.37us	-5.32
substrate/frame/indices/src/weights.rs	poke_deposit		145.46us	Added
polkadot/runtime/westend/src/weights/pallet_indices.rs	poke_deposit		153.18us	Added
polkadot/runtime/rococo/src/weights/pallet_indices.rs	poke_deposit		149.23us	Added

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_indices']
-- westend: ['pallet_indices']
-- rococo: ['pallet_indices']

[re-gius]

LGTM