Add missing events to nomination pool extrinsics #7377
Conversation
rockbmb
added
T1-FRAME
Ank4n
left a comment
Ank4n
left a comment
There was a problem hiding this comment.
Some nits but okay with this PR.
| /// A pool member's claim permission has been updated. | ||
| MemberClaimPermissionUpdated { member: T::AccountId, permission: ClaimPermission }, | ||
| /// A pool's metadata was updated. | ||
| MetadataUpdated { pool_id: PoolId, caller: T::AccountId }, |
There was a problem hiding this comment.
Is adding caller useful here? Nothing against it, just trying to understand the rationale. Same for other events.
There was a problem hiding this comment.
In the case of set_metadata, both the pool's root and its bouncer can make that call - this is to disambiguate which did it, in case the two roles are performed by different accounts.
The same goes for the other calls: nominate/chill can be called by the pool's root/nominator.
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rockbmb
changed the title
Found via open-web3-stack/polkadot-ecosystem-tests#165.
Closes #7370 .
Description
Some extrinsics from
pallet_nomination_poolswere not emitting events:set_configsset_claim_permissionset_metadatachillnominateIntegration
N/A
Review Notes
N/A