[pallet-broker] add extrinsic to remove an assignment #7080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@re-gius can you run this command? |
|
@ethernomad Requester could not be detected as a member of an allowed organization. |
ethernomad
changed the title
seadanda
reviewed
Jan 9, 2025
8 tasks
added 7 commits
January 10, 2025 12:12
Contributor
Author
|
Can someone run the benchmarking? |
Contributor
|
/cmd bench --pallet pallet_broker --runtime coretime-rococo coretime-westend dev |
Contributor
|
Command "bench --pallet pallet_broker --runtime coretime-rococo coretime-westend dev" has started 🚀 See logs here |
…runtime coretime-rococo coretime-westend dev'
Contributor
|
Command "bench --pallet pallet_broker --runtime coretime-rococo coretime-westend dev" has finished ✅ See logs here Subweight results:
Command output:❌ Failed to build coretime-rococo |
seadanda
reviewed
Feb 19, 2025
| } | ||
|
|
||
| #[benchmark] | ||
| fn remove_assignment() -> Result<(), BenchmarkError> { |
Contributor
There was a problem hiding this comment.
You need to also add this to the weights files for coretime-westend and coretime-rococo. Check the output of clippy (or the clippy CI job)
Contributor
Author
|
@seadanda okay I fixed the build. Can you try the benchmarking again? |
Contributor
|
/cmd bench --pallet pallet_broker --runtime coretime-rococo coretime-westend |
Contributor
|
Command "bench --pallet pallet_broker --runtime coretime-rococo coretime-westend" has started 🚀 See logs here |
…runtime coretime-rococo coretime-westend'
Contributor
|
Command "bench --pallet pallet_broker --runtime coretime-rococo coretime-westend" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
Member
|
@ethernomad please merge master |
Contributor
Author
|
please run benchmarking |
bkchr
approved these changes
Feb 19, 2025
Member
|
/tip small |
Member
We don't need to run them for every pr. They will be updated by the weekly job. |
|
@bkchr A referendum for a small (4 KSM) tip was successfully submitted for @ethernomad (HnQ5ufmTTZrKKhsYk4HdoScHiQyK7PSxNDVNS5YYvgoNB53 on kusama). Referendum number: 496. |
Member
|
Also the benchmarks were running already. |
|
The referendum has appeared on Polkassembly. |
seadanda
approved these changes
Feb 19, 2025
Merged
via the queue into
paritytech:master
with commit Feb 19, 2025
bd41848
250 of 257 checks passed
7 tasks
This was referenced Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6929 requests more extrinsics for "managing the network's coretime allocations without needing to dabble with migration+runtime upgrade or set/kill storage patterns"
This pull request implements the remove_assignment() extrinsic.
Integration
Downstream projects need to benchmark the weight for the remove_assignment() extrinsic.