Skip to content

Conversation

@muraca
Copy link
Contributor

@muraca muraca commented Jan 12, 2025

Description

Part of #3326

As per title, the pallet:getter usage has been removed from:

  • pallet-bridge-beefy
  • pallet-bridge-grandpa
  • pallet-bridge-messages
  • pallet-bridge-relayers
  • pallet-xcm-bridge-hub-router

polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp

@muraca muraca marked this pull request as ready for review January 12, 2025 16:49
@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 12, 2025 16:50
@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Jan 14, 2025
@ggwpez
Copy link
Member

ggwpez commented Jan 14, 2025

/tip small

@substrate-tip-bot
Copy link

@ggwpez A referendum for a small (20 DOT) tip was successfully submitted for @muraca (12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp on polkadot).

Referendum number: 1385.
tip

@substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 15, 2025 14:12
@muraca muraca requested a review from bkontur February 14, 2025 10:05
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 8, 2025 14:13
@bkontur
Copy link
Contributor

bkontur commented Mar 10, 2025

@muraca please also check #[pallet::getter(fn bridge)] and #[pallet::getter(fn request_count)] so we clean all the stuff

@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 10, 2025 09:14
@muraca
Copy link
Contributor Author

muraca commented Mar 10, 2025

@bkontur I have handled pallet-bridge-beefy and pallet-xcm-bridge-hub-router as well

@muraca muraca requested a review from bkontur March 10, 2025 09:39
@bkontur
Copy link
Contributor

bkontur commented Mar 10, 2025

@bkontur
Copy link
Contributor

bkontur commented Mar 10, 2025

/cmd fmt

@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 10, 2025 10:02
@bkontur
Copy link
Contributor

bkontur commented Mar 11, 2025

/cmd fmt

@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 11, 2025 15:07
@bkontur
Copy link
Contributor

bkontur commented Mar 11, 2025

/cmd fmt

@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 11, 2025 21:08
@bkontur bkontur enabled auto-merge March 11, 2025 21:20
@bkontur bkontur added this pull request to the merge queue Mar 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2025
@bkontur bkontur added this pull request to the merge queue Mar 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2025
@bkontur bkontur enabled auto-merge March 13, 2025 09:38
@bkontur bkontur added this pull request to the merge queue Mar 13, 2025
Merged via the queue into paritytech:master with commit 66e3196 Mar 13, 2025
233 of 243 checks passed
ordian added a commit that referenced this pull request Mar 17, 2025
* origin: (325 commits)
  Add an extra_constant to pallet-treasury (#7918)
  Bump the ci_dependencies group across 1 directory with 4 updates (#7855)
  remove compromised action (#7934)
  Fixing token-economics dead link (#5302)
  [pallet-revive] Fix pallet-revive-fixtures build.rs (#7928)
  cumulus: fix pov exporter format (#7923)
  sp-api: Support `mut` in `impl_runtime_apis!` (#7924)
  Remove clones from block seal function (#7917)
  [pallet-revive] precompiles 2->9 (#7810)
  Use non-native token to benchmark xcm on asset hub (#7893)
  [CI] bump timeout wait for build in zombienet workflows. (#7871)
  taplo: split long array line to multiline array (#7905)
  [pallet-revive] fixture as dev dep (#7844)
  notifications/libp2p: Punish notification protocol misbehavior on outbound substreams (#7781)
  [Release|CI/CD] Update version of the cache action in the Publish docker ci (#7892)
  Remove `pallet::getter` usage from bridges/modules (#7120)
  [pallet-revive] Support blocktag in eth_getLogs RPC (#7879)
  Improve error message in benchmark macro (#7873)
  staking: add `manual_slash` extrinsic (#7805)
  Remove execute_with_origin implementation in the XCM executor (#7889)
  ...
alindima pushed a commit that referenced this pull request Apr 8, 2025
# Description

Part of #3326 

As per title, the `pallet:getter` usage has been removed from:
- `pallet-bridge-beefy`
- `pallet-bridge-grandpa`
- `pallet-bridge-messages`
- `pallet-bridge-relayers`
- `pallet-xcm-bridge-hub-router`


polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp

---------

Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T2-pallets This PR/Issue is related to a particular pallet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants