Skip to content

Conversation

@bkchr
Copy link
Member

@bkchr bkchr commented Dec 3, 2024

No need to have them in the umbrella crate also by having them in the umbrella crate they are bleeding into the normal build.

No need to have them in the umbrella crate also by having them in the umbrella crate they are bleeding into the normal build.
@bkchr bkchr added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Dec 3, 2024
@bkchr bkchr requested a review from athei December 3, 2024 16:28
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense. Frame users won't need them.

@athei athei requested a review from pgherveou December 3, 2024 16:31
@bkchr bkchr enabled auto-merge December 3, 2024 16:41
@bkchr
Copy link
Member Author

bkchr commented Dec 3, 2024

/cmd prdoc --audience runtime_dev --bump major

@bkchr bkchr requested a review from xermicus December 4, 2024 02:01
@bkchr bkchr added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit a2ffae3 Dec 4, 2024
198 of 203 checks passed
@bkchr bkchr deleted the bkchr-remove-pallet-revive-fixtures-from-umbrella branch December 4, 2024 10:28
Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this pull request Dec 18, 2024
No need to have them in the umbrella crate also by having them in the
umbrella crate they are bleeding into the normal build.

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Alexander Theißen <[email protected]>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this pull request Jan 4, 2025
No need to have them in the umbrella crate also by having them in the
umbrella crate they are bleeding into the normal build.

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Alexander Theißen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants