[staking] Currency Migration and Overstake fix #7763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ank4n
changed the title
Contributor
Author
|
/cmd prdoc |
Ank4n
added
A3-backport
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
40 tasks
kianenigma
approved these changes
Mar 12, 2025
tdimitrov
approved these changes
Mar 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Ank4n
removed
the
A3-backport
Ank4n
added
A3-backport
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7763-to-stable2407
git worktree add --checkout .worktree/backport-7763-to-stable2407 backport-7763-to-stable2407
cd .worktree/backport-7763-to-stable2407
git reset --hard HEAD^
git cherry-pick -x f540d2b3d26d24a952e792cdae05bb89c43e5173
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7763-to-stable2409
git worktree add --checkout .worktree/backport-7763-to-stable2409 backport-7763-to-stable2409
cd .worktree/backport-7763-to-stable2409
git reset --hard HEAD^
git cherry-pick -x f540d2b3d26d24a952e792cdae05bb89c43e5173
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7763-to-stable2412
git worktree add --checkout .worktree/backport-7763-to-stable2412 backport-7763-to-stable2412
cd .worktree/backport-7763-to-stable2412
git reset --hard HEAD^
git cherry-pick -x f540d2b3d26d24a952e792cdae05bb89c43e5173
git push --force-with-lease |
github-actions bot
added a commit
that referenced
this pull request
Mar 13, 2025
## Summary The existing fungible migration code has an issue when handling partially unbonding accounts, leaving them in an inconsistent state. These changes fix it by properly withdrawing overstake from unlock chunks. This PR also removes the `withdraw_overstake` extrinsic from pallet-staking, as this scenario could only occur before the fungible migration. With fungibles, over-staking is no longer possible. ## TODO - [ ] Backport to stable2503. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit f540d2b)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Mar 17, 2025
Backport #7763 into `stable2503` from Ank4n. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Ankan <[email protected]>
11 tasks
alindima
pushed a commit
that referenced
this pull request
Apr 8, 2025
## Summary The existing fungible migration code has an issue when handling partially unbonding accounts, leaving them in an inconsistent state. These changes fix it by properly withdrawing overstake from unlock chunks. This PR also removes the `withdraw_overstake` extrinsic from pallet-staking, as this scenario could only occur before the fungible migration. With fungibles, over-staking is no longer possible. ## TODO - [ ] Backport to stable2503. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
7 tasks
This was referenced Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing fungible migration code has an issue when handling partially unbonding accounts, leaving them in an inconsistent state. These changes fix it by properly withdrawing overstake from unlock chunks.
This PR also removes the
withdraw_overstakeextrinsic from pallet-staking, as this scenario could only occur before the fungible migration. With fungibles, over-staking is no longer possible.TODO