-
Notifications
You must be signed in to change notification settings - Fork 140
Bump to stable2503
#711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bump to stable2503
#711
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
69273cd
Bump to stable2503
athei 1677663
Disable encointer
athei 67f29bd
Copy over weight files from PolkadotSDK
athei ad9a484
Derive DecodeWithMemTracking
athei 5163229
Change pallet referenda TracksInfo::tracks to return an iterator
athei 4b3e9db
Add BlockNumberProvider
athei 38466df
[AHM] Moves disabling logic into pallet-session
athei d977ff3
[Nomination Pool] Make staking restrictions configurable
athei 21cd816
[Staking] Currency <> Fungible migration
athei 34e9e4c
chore: fix zepter
pandres95 d006154
chore: Update to `stable2503-1`
pandres95 a030017
fix(relay): resolve build issues for relay chain runtimes
pandres95 2a37f9a
fix(system-parachains/collectives): resolve build issues for collecti…
pandres95 fdd487d
fix(system-parachains/coretime): resolve build issues for coretime pa…
pandres95 12f5d54
chore(bridge-hub-polkadot-runtime): add new deps for snowbridge
pandres95 1393700
fix(system-parachains/bridge-hubs): resolve build issues for bridge h…
pandres95 4bea49c
fix(system-parachains/asset-hubs): resolve build issues for asset hub…
pandres95 7c71e6c
Merge pull request #1 from pandres95/at/2503
athei f6f53ad
fmt
athei 514205a
Add missing dev account genesis
athei fcd5d96
Taplo
athei bfb5931
Switch away from snowbridge-router-primitives
athei 795b686
Add more missing genesis fields
athei 46038d9
Xcm config fixes
athei 7c72c8f
Fix tests
athei d5c349c
Remove no longer needed filter for snowbridge
athei 233a9ea
Fix more missing genesis fields
athei 6bdedf4
Fix snowbridge tests
athei ed5b898
Fix staking config for fungibles transition
athei f3c3fc5
Add missing genesis fields
athei 5f6b147
Remove unused fields
athei 8f5884a
Remove syntax zepter does not understand
athei 5df6026
taplo
athei 8b9fa9c
Revert "Disable encointer"
clangenb 6683b22
bump encointer
clangenb bfc271f
encointer 2503 fixes
clangenb 3893cbc
encointer 2503 fixes
clangenb 8bd16ed
fmt
clangenb 78f6de3
Merge pull request #2 from encointer/cl/bump-encointer
athei 541b2be
fix snowbridge tests
claravanstaden 8254b5e
Merge pull request #3 from Snowfork/snowbridge-2503
athei 48ee0d2
Merge branch 'main' into at/2503
athei 7645a74
Allow deprecated functions
athei 70d08dd
Need to forward `try-runtime` or a `--all-features` build will break
athei 27d89fe
zepter
athei e457d7f
Remove unused import in benchmarking code
athei 4e4f654
Update to polkadot-stable2503-2
athei 6a34a7b
Update changelog
athei 904f0fd
Add missing migrations
athei 7220f1c
Taplo
athei fe1794c
Revert back some bridge weights to pass: can_calculate_fee_for_standa…
bkontur 30c1441
Merge pull request #4 from bkontur/bko-on-at-2503
athei 3f7c44b
Merge branch 'main' into at/2503
athei abcf7f5
Fix for relay benchmarks
bkontur 1241209
Revert "Copy over weight files from PolkadotSDK"
athei 990be64
Add missing weight functions
athei 7d2b037
Migration for BHK
bkontur 2950415
Moved to common for BHP
bkontur 799169e
Refactor rewards for BHP
bkontur 3a9130d
Imports
bkontur ec5c47b
Merge pull request #5 from bkontur/bko-on-at-2503
athei d270ec3
Merge pull request #6 from bkontur/bko-on-athei-at-2503
athei ca4ca75
Fix BHP benchmarks
bkontur 5132b52
Add broker block number conversion migration
seadanda 1b7becb
Also advance relay block number in coretime tests
seadanda 255ab5a
Merge pull request #7 from bkontur/bko-on-athei-at-2503
athei 5d9ee51
Merge pull request #8 from seadanda/donal-broker-blocknumber-migration
athei 52ded3a
fix Polkadot SDK stable2503 integration and fix integration tests
acatangiu 6b8ee60
Merge pull request #9 from acatangiu/fix-2503-integration
athei 89381ad
Fix clippy lints
athei fc8b859
Update frame-omni-bencher
athei 2e221c8
Update to polkadot-stable2503-5
athei c5e132b
Merge branch 'main' into at/2503
athei 1bed425
remove dual stake filter
Ank4n c94838a
Merge pull request #11 from Ank4n/ankn/at/2503
athei 0137eb8
Apply suggestions from code review
athei 7cb5438
Merge branch 'main' into at/2503
athei 691f2df
Merge branch 'main' into at/2503
athei 05ef52a
Update CHANGELOG.md
athei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is no sufficient for downstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is downstream? This is a binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agree, I had an open todo to add a pr here with more details.
user of the runtime, end users or dApps calling runtime APIs
we need to surface here all the changes marked as audience “runtime user” from the updated SDK (get them from release notes of 2503, 2503-1, .., 2503-5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a LOT of changes flagged for runtime dev. Should they all be copy pasted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only runtime user, but I think usually some of these are mislabelled
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK this is probably a better filter to select only impactful changes: this includes PRs which cause major bumps in non-testnet crates:
Major and non-testnet
Make pallet-recovery supports
BlockNumberProviderSDK #6446Implementation of
ah-clientandrc-clientstaking pallets SDK #7582[staking] Currency Migration and Overstake fix SDK #7763
Adds multi-block election types and refactors current single logic to support it SDK #6034
Only allow apply slash to be executed if the slash amount is atleast ED SDK #6540
dmp: Check that the para exist before delivering a message SDK #6604
Remove
ProspectiveParachainsModefrom backing subsystem SDK #6215[AHM] Poke deposits: Multisig pallet SDK #7700
fatxpool: handling limits and priorities improvements SDK #6405pallet-revive: Adjust error handling of sub calls SDK #6741
Add chain-spec-builder as a subcommand to the polkadot-omni-node SDK #7619
Remove
yamux_window_sizefrom network config SDK #7014apply_authorized_upgrade: Remote authorization if the version check fails SDK #7812Add and test events to conviction voting pallet SDK #6544
[core-fellowship] Add permissionless import_member SDK #7030
Snowbridge - Ethereum Electra Upgrade Support SDK #7075
runtimes: presets are provided as config patches SDK #6349
deprecate AsyncBackingParams SDK #7254
Make the default 85% usage of the PoV SDK #8040
umbrella: Remove
pallet-revive-fixturesSDK #6743Bounded Slashing: Paginated Offence Processing & Slash Application SDK #7424
Dynamic uncompressed code size limit SDK #7760
Move validator disabling logic to pallet-session SDK #7581
Optimize origin checks SDK #8000
Update Conviction Voting Pallet to Support Block Number Provider SDK #6621
pallet_revive: Switch to 64bit RISC-V SDK #6565
Use Relay Blocknumber in Pallet Broker SDK #5656
Upgrade libp2p to 0.54.1 SDK #6248
Stabilize RPC
archivemethods to V1 SDK #8104sync: Send already connected peers to new subscribers SDK #7011
Remove network starter that is no longer needed SDK #6400
revive: Include immutable storage deposit into the contracts
storage_base_depositSDK #7230Snowbridge V2 SDK #7402
Add voting hooks to Conviction_Voting SDK #7703
Introduce pallet-asset-rewards SDK #3926
Removes constraint in BlockNumberProvider from treasury SDK #6522
Update Society Pallet to Support Block Number Provider SDK #6623
Add Runtime Api version to metadata SDK #7607
pallet-xcm: add support to authorize aliases SDK #6336
Add missing events to nomination pool extrinsics SDK #7377
Implement
pallet-assets-holderand consider ED part of frozen amount inpallet-assetsSDK #4530[AHM] Poke deposits: Indices pallet SDK #7587
pallet_revive: Change address derivation to use hashing SDK #7662
Remove usage of AccountKeyring SDK #5899
slot-based-collator: Implement dedicated block import SDK #6481
Fix XCM decoding inconsistencies SDK #7856
[pallet-xcm] waive transport fees based on XcmConfig SDK #5363
slot-based-collator: Move spawning of the futures SDK #6561
Add EventEmitter to XCM Executor SDK #7234
Update Scheduler to have a configurable block number provider SDK #7441
pallet-revive: Fix docs.rs SDK #6896
Add export PoV on slot base collator SDK #7585
[pallet-revive] Update delegate_call to accept address and weight SDK #6111
Remove unused dependencies from pallet_revive SDK #6917
revive: Rework the instruction benchmark SDK #7721
pallet-revive: Statically verify imports on code deployment SDK #6759
Implement pallet view functions SDK #4722
[pallet-revive] implement the gas limit API SDK #6926
Remove pallet::getter from bridges/modules SDK #7120
[pallet-revive] implement the block author API SDK #7198
basic-authorship: debug level is now less spammy SDK #6768Return iterator in pallet_referenda::TracksInfo::tracks SDK #2072
Remove feature
test-helpersfrom sc-service SDK #5855Deprecate ParaBackingState API SDK #6867
frame-benchmarking: Use correct components for pallet instances SDK #6435
TransactionPool API uses async_trait SDK #6528
AHM Multi-block staking election pallet SDK #7282
[pallet-broker] add extrinsic to remove a lease SDK #7026
Currency to Fungible migration for pallet-staking SDK #5501
Migrate executor into PolkaVM 0.18.0 SDK #6533
Make
pallet-bridge-rewardsgeneric overRewardKindSDK #7492[pallet-revive] change some getter APIs to return value in register SDK #6920
[pallet-revive] Remove debug buffer SDK #7163
Rename archive call method result to value SDK #7885
Remove node-side feature flag checks for Elastic Scaling MVP SDK #7286
Revert pallet-staking changes which should be released as a separate pallet SDK #7939
Utility call fallback SDK #6321
remove handling of validation protocol versions 1 and 2 SDK #7449
[XCM] allow signed account to be aliased between system chains SDK #7983
derive
DecodeWithMemTrackingforBlockSDK #7655runtime-api: remove redundant version checks SDK #7610
slot-based-collator: Allow multiple blocks per slot SDK #7569
Remove pallet::getter from pallet-nft-fractionalization SDK #7124
Add omni-node checks for runtime parachain compatibility SDK #6450
[net/libp2p] Use raw
Identifyobserved addresses to discover external addresses SDK #7338Update Referenda to Support Block Number Provider SDK #6338
FRAME: Meta Transaction SDK #6428
[pallet-revive] allow delegate calls to non-contract accounts SDK #7729
derive
DecodeWithMemTrackingforRuntimeCallSDK #7634Allow configurable number of genesis accounts with specified balances for benchmarking. SDK #6267
[pallet-revive] implement the call data copy API SDK #6880
[pallet-revive] Fix
caller_is_rootreturn value SDK #7086Pallet view functions: improve metadata, API docs and testing SDK #7412
pallet-revive: Remove unused dependencies SDK #6796
New
staking::manual_slashextrinsic SDK #7805On-demand credits SDK #5990
[pallet-revive] Remove revive events SDK #7164
Adds
BlockNumberProviderin multisig, proxy and nft pallets SDK #5723Expose DHT content providers API from
sc-networkSDK #6711[pallet-broker] add extrinsic to reserve a system core without having to wait two sale boundaries SDK #4273
Accurate weight reclaim with frame_system::WeightReclaim and cumulus
StorageWeightReclaimtransaction extensions SDK #6140Remove ReportCollator message SDK #6628
[pallet-revive] pack exceeding syscall arguments into registers SDK #7319
Refactor
pallet-revive-uapipallet SDK #6866Assume elastic scaling MVP feature is always enabled in the runtime SDK #7986
[mq pallet] Custom next queue selectors SDK #6059
rpc v2 archive: more verbose error types in API SDK #8109
Introduce ark-ec-vrfs SDK #7669
pallet-revive: Fix the contract size related benchmarks SDK #7568
Update Nomination Pool Pallet to Support Block Number Provider SDK #6715
[pallet-broker] add extrinsic to remove an assignment SDK #7080
[pallet-revive] do not trap the caller on instantiations with duplicate contracts SDK #7414
Forbid v1 descriptors with UMP signals SDK #7127
add poke_deposit extrinsic to pallet-proxy SDK #7801
pallet-revive: disable host functions unused in solidity PolkaVM compiler SDK #6844
Authorize upgrade tests for testnet runtimes +
execute_as_governancerefactor SDK #7656[FRAME] Omni bencher fixes SDK #8265
[pallet-revive] tracing prepare support for future tracing APIS SDK #8495
fix epmb solution duplicate issue + add remote mining apparatus to epm SDK #8585
Fix a potential cause of slow parachain blocks SDK #8447
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we don't care about major bumps if the audience does not contain
Runtime User- that's why we have audiences, let's filter based on the right one.later edit: the list above from Oliver looks good 👍
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used that filter (the first list I posted) and it misses a huge amount that users would be interested in but which the sdk prdoc does not include a runtime user section - that's what I meant that we're building on a weak base
edit: also happy with Oliver's list including runtime user and runtime dev. It would be nice to further refine this in future to skip the PR descriptions involving only testnet code/crates not used in this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea it is a data-ingestion problem. Garbage-in-garbage out... The dev who merges it is basically the one responsible for good PrDoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a proposal for tracking work past implementation to integration which should help with this Changelog situation as well.
We can discuss more live in tomorrow's Runtime Weekly Hangout, so join if you're interested in the topic.
TLDR: if we have a process and track features/fixes/etc all the way to integration to runtimes, we can create a "runtime-user-audience-tailored changelog entry" required step of the integration. E.g. I added a new pallet to SDK, when I integrate to runtimes I need to also add high-quality changelog entry explaining the new thing added to the runtime.