Skip to content

sc-executor-polkavm: Migrate into PolkaVM 0.18.0 #6533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 74 commits into from
Dec 14, 2024
Merged

sc-executor-polkavm: Migrate into PolkaVM 0.18.0 #6533

merged 74 commits into from
Dec 14, 2024

Conversation

@jarkkojs
Copy link
Contributor

@jarkkojs jarkkojs commented Nov 18, 2024 •
edited
Loading

Bump polkavm to 0.18.0, and update sc-polkavm-executor to be compatible with the API changes. In addition, bump also polkavm-derive and polkavm-linker in order to make sure that the all parts of the Polkadot SDK use the exact same ABI for .polkavm binaries.

Purely relying on RV32E/RV64E ABI is not possible, as PolkaVM uses a RISCV-V alike ISA, which is derived from RV32E/RV64E but it is still its own microarchitecture, i.e. not fully binary compatible.

@jarkkojs jarkkojs self-assigned this Nov 18, 2024
@jarkkojs jarkkojs added the T0-node This PR/Issue is related to the topic “node”. label Nov 18, 2024
athei
athei reviewed Nov 19, 2024
View reviewed changes
Bump polkavm version to 0.16.0
f91a828 
Signed-off-by: Jarkko Sakkinen <[email protected]>
@jarkkojs jarkkojs marked this pull request as ready for review November 20, 2024 03:58
@jarkkojs jarkkojs requested a review from koute as a code owner November 20, 2024 03:58
@jarkkojs jarkkojs requested a review from athei November 20, 2024 04:00
Remove unused import
618dc43 
Signed-off-by: Jarkko Sakkinen <[email protected]>
@jarkkojs
Copy link
Contributor Author

jarkkojs commented Nov 20, 2024

BTW, please help me to interpret the CI errors...

koute
koute reviewed Nov 20, 2024
View reviewed changes
jarkkojs and others added 2 commits November 21, 2024 00:12
@jarkkojs @koute
Update Cargo.toml
86179c2 
Co-authored-by: Koute <[email protected]>
Drop polkavm-common
1bae57b 
Signed-off-by: Jarkko Sakkinen <[email protected]>
@jarkkojs
Copy link
Contributor Author

jarkkojs commented Nov 21, 2024

@koute no further answers needed despite some questions. I'll ping you at chat if anything. After taking yesterday off comments feel somewhat clear.

Jarkko Sakkinen added 7 commits November 21, 2024 20:12
sc-executor-common: Use polkavm::ArcBytes to store the raw blob
1f888ed 
Signed-off-by: Jarkko Sakkinen <[email protected]>
sc-executor-polkavm: remove unnecessary unwrap
cfa00ce 
Signed-off-by: Jarkko Sakkinen <[email protected]>
sc-executor-polkavm: address unwraps and restore code
5b37507 
Signed-off-by: Jarkko Sakkinen <[email protected]>
sc-executor-polkavm: fix exception handling in call_with_allocation_s…
0582e94 
…tats()

Signed-off-by: Jarkko Sakkinen <[email protected]>
sc-executor-polkavm: Restore allocate_memory()
f173aae 
Signed-off-by: Jarkko Sakkinen <[email protected]>
sc-executor-polkavm: Fix allocate_memory() error handling
2590aab 
Signed-off-by: Jarkko Sakkinen <[email protected]>
sc-executor-polkavm: Fix 64-bit reg handling in call_host_function()
def26a5 
Signed-off-by: Jarkko Sakkinen <[email protected]>
@jarkkojs jarkkojs requested a review from koute November 21, 2024 21:04
@jarkkojs
Copy link
Contributor Author

jarkkojs commented Nov 21, 2024

I'm sure I missed something but did my best ;-)

@jarkkojs
Copy link
Contributor Author

jarkkojs commented Nov 21, 2024

2x oldlinux tests failing

@jarkkojs
Copy link
Contributor Author

jarkkojs commented Dec 14, 2024

I guess it's produced during the std (native) runtime build, so just putting the min_stack_size! call under the same #[cfg] conditions should be enough. Btw, it would be good to have succinct macros to generate those cfgs, copy-pasting them over the code does not add to readability.

Yeah should be good enough for the moment. Otherwise this becomes two-crate problem and that weights worse for the time being...

Adjust min_stack_size
72ec780 
Signed-off-by: Jarkko Sakkinen <[email protected]>
@jarkkojs
Copy link
Contributor Author

jarkkojs commented Dec 14, 2024

OK great. After expanding to 32 kB stack does not overrun. I have now node running.

@jarkkojs jarkkojs enabled auto-merge December 14, 2024 11:56
@s0me0ne-unkn0wn
Copy link
Contributor

s0me0ne-unkn0wn commented Dec 14, 2024

Running and not doing much useful work, right? I bet if you put it under some load, it'll start overflowing again. I'd use some conservative stack limit like 2 Mb. Given that we currently use a 256 Mb stack limit for Wasm PVFs, that doesn't sound like too much. Curious to hear @koute's opinion on that. And definitely needs a burn-in before going any closer to production ;)

@jarkkojs jarkkojs disabled auto-merge December 14, 2024 12:00
Adjust min_stack_size to 2MB
db0fed9 
Signed-off-by: Jarkko Sakkinen <[email protected]>
@jarkkojs
Copy link
Contributor Author

jarkkojs commented Dec 14, 2024

Running and not doing much useful work, right? I bet if you put it under some load, it'll start overflowing again. I'd use some conservative stack limit like 2 Mb. Given that we currently use a 256 Mb stack limit for Wasm PVFs, that doesn't sound like too much. Curious to hear @koute's opinion on that. And definitely needs a burn-in before going any closer to production ;)

Increased to 2 MiB

@jarkkojs
Copy link
Contributor Author

jarkkojs commented Dec 14, 2024

Running and not doing much useful work, right? I bet if you put it under some load, it'll start overflowing again. I'd use some conservative stack limit like 2 Mb. Given that we currently use a 256 Mb stack limit for Wasm PVFs, that doesn't sound like too much. Curious to hear @koute's opinion on that. And definitely needs a burn-in before going any closer to production ;)

Increased to 2 MiB

It's not the only thing that needs to be possibly tuned after this PR. Node starting is good enough DoD.

@jarkkojs jarkkojs enabled auto-merge December 14, 2024 13:36
Jarkko Sakkinen added 4 commits December 14, 2024 15:47
asm_const
2aff575 
Signed-off-by: Jarkko Sakkinen <[email protected]>
Adjust min_stack_size definition
e132b7c 
Signed-off-by: Jarkko Sakkinen <[email protected]>
Adjust min_stack_size definition
8b0fcd6 
Signed-off-by: Jarkko Sakkinen <[email protected]>
add SUBSTRATE_ENABLE_POLKAVM=1 to .github/workflows/build-misc.yml
82ab893 
Signed-off-by: Jarkko Sakkinen <[email protected]>
@jarkkojs jarkkojs requested review from a team as code owners December 14, 2024 14:06
@jarkkojs jarkkojs added this pull request to the merge queue Dec 14, 2024
Merged via the queue into paritytech:master with commit bd2c35f Dec 14, 2024
196 of 199 checks passed
@jarkkojs jarkkojs deleted the bump-polkavm-version branch December 14, 2024 19:52
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this pull request Jan 4, 2025
@koute @athei @dudo50
sc-executor-polkavm: Migrate into PolkaVM 0.18.0 (paritytech#6533)
7761fc8 
Bump `polkavm` to 0.18.0, and update `sc-polkavm-executor` to be
compatible with the API changes. In addition, bump also `polkavm-derive`
and `polkavm-linker` in order to make sure that the all parts of the
Polkadot SDK use the exact same ABI for `.polkavm` binaries.

Purely relying on RV32E/RV64E ABI is not possible, as PolkaVM uses a
RISCV-V alike ISA, which is derived from RV32E/RV64E but it is still its
own microarchitecture, i.e. not fully binary compatible.

---------

Signed-off-by: Jarkko Sakkinen <[email protected]>
Co-authored-by: Koute <[email protected]>
Co-authored-by: Alexander Theißen <[email protected]>
@ggwpez ggwpez mentioned this pull request Jun 4, 2025
Merged
7 tasks
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Closed
This was referenced Jul 16, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athei athei athei approved these changes

@s0me0ne-unkn0wn s0me0ne-unkn0wn s0me0ne-unkn0wn approved these changes

@koute koute Awaiting requested review from koute koute is a code owner

Assignees

@jarkkojs jarkkojs

Labels

T0-node This PR/Issue is related to the topic “node”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jarkkojs @athei @koute @s0me0ne-unkn0wn