Skip to content

Use media player image proxy for roku media browser#43070

Merged
balloob merged 17 commits intodevfrom
ctalkington-roku-media-proxy
Nov 11, 2020
Merged

Use media player image proxy for roku media browser#43070
balloob merged 17 commits intodevfrom
ctalkington-roku-media-proxy

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented Nov 10, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added integration: roku small-pr PRs with less than 30 lines. labels Nov 10, 2020
@ctalkington ctalkington changed the title Use media player proxy for roku media browser images Use media player image proxy for roku media browser Nov 11, 2020
@ctalkington ctalkington marked this pull request as ready for review November 11, 2020 01:47
balloob
balloob reviewed Nov 11, 2020
View reviewed changes
Comment thread homeassistant/components/media_player/__init__.py Outdated
balloob
balloob reviewed Nov 11, 2020
View reviewed changes
Comment thread homeassistant/components/roku/media_player.py
"""Implement the websocket media browsing helper."""

def _get_thumbnail_url(*args, **kwargs):
return self.get_browse_image_url(*args, **kwargs)
Copy link
Copy Markdown
Member

@balloob balloob Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add same logic as #43089

Copy link
Copy Markdown
Contributor Author

@ctalkington ctalkington Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the issue with roku images is they arent accessible over https so wed need a bit deeper of a check to check if internal and non-https request.

Copy link
Copy Markdown
Member

@balloob balloob Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right. Squeezebox will have the same issue.

Copy link
Copy Markdown
Member

@balloob balloob Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that is not a problem. Locally there can't be valid SSL anyway

Copy link
Copy Markdown
Contributor Author

@ctalkington ctalkington Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok. I can look into doing an update tonight for internal check

balloob
balloob reviewed Nov 11, 2020
View reviewed changes
Comment thread homeassistant/components/roku/media_player.py Outdated
ctalkington
ctalkington commented Nov 11, 2020
View reviewed changes
Comment thread homeassistant/components/media_player/__init__.py Outdated
@balloob balloob merged commit df5a8c4 into dev Nov 11, 2020
@balloob balloob deleted the ctalkington-roku-media-proxy branch November 11, 2020 19:17
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 11, 2020
Merge branch 'dev' of https://github.com/home-assistant/core into dev
907fe3f 
* 'dev' of https://github.com/home-assistant/core: (552 commits)
  Use media player image proxy for roku media browser (home-assistant#43070)
  Add Shelly support for REST sensors (home-assistant#40429)
  Add system health section for the Supervisor (home-assistant#43074)
  Simplify distance conversion (home-assistant#43107)
  Add initial rest query params (home-assistant#42198)
  Bump pycsspeechtts to 1.0.4 (home-assistant#43105)
  Bump greeclimate to 0.9.6 (home-assistant#43106)
  Add reboot and shutdown service to synology_dsm (home-assistant#42697)
  Bump up ZHA dependencies (home-assistant#43104)
  Modify wait timeout in stream (home-assistant#42794)
  Bumped version to 0.117.6
  Fix Plex auth issues by setting header (home-assistant#43081)
  Bump gTTS-token to 1.1.4 (home-assistant#43015)
  Bump pwmled to v1.6.7 (home-assistant#42903)
  Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration (home-assistant#42804)
  Update frontend to 20201111.0 (home-assistant#43101)
  Show media progress in sisyphus (home-assistant#42996)
  Use internal url for Squeezebox if possible (home-assistant#43089)
  Add watchdog to reset nest subscriber (home-assistant#43034)
  Bump hatasmota to 0.0.29 (home-assistant#43013)
  ...
@ctalkington ctalkington mentioned this pull request Nov 12, 2020
Closed
21 tasks
@frenck frenck added this to the 0.118.0 milestone Nov 12, 2020
balloob pushed a commit that referenced this pull request Nov 13, 2020
@ctalkington @balloob
Use media player image proxy for roku media browser (#43070)
e7ce894
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

No one assigned

Labels

by-code-owner cherry-picked cla-signed integration: roku small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.118.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ctalkington @balloob @frenck @homeassistant