Skip to content

Bump pwmled to v1.6.7#42903

Merged
frenck merged 1 commit intohome-assistant:devfrom
soldag:dev
Nov 6, 2020
Merged

Bump pwmled to v1.6.7#42903
frenck merged 1 commit intohome-assistant:devfrom
soldag:dev

Conversation

@soldag
Copy link
Copy Markdown
Contributor

@soldag soldag commented Nov 6, 2020

Proposed change

Fixes an issue when using rpi_gpio_pwm integration to control leds connected via GPIOs, which was introduced in previous version of the library.

soldag/python-pwmled@v1.6.6...v1.6.7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added bugfix dependency Pull requests marked as a dependency upgrade integration: rpi_gpio_pwm small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file by-code-owner labels Nov 6, 2020
@frenck frenck added this to the 0.117.6 milestone Nov 6, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @soldag 👍

@frenck frenck merged commit bf9f3e1 into home-assistant:dev Nov 6, 2020
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade dependency-bump Pull requests that update a dependency file integration: rpi_gpio_pwm small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rpi_gpio_pwm error after upgrade to 0.117.* ('NoneType' object has no attribute 'send')

3 participants