Skip to content

Bump greeclimate to 0.9.6#43106

Merged
frenck merged 1 commit intohome-assistant:devfrom
cmroche:gree-discovery-fix-20201111
Nov 11, 2020
Merged

Bump greeclimate to 0.9.6#43106
frenck merged 1 commit intohome-assistant:devfrom
cmroche:gree-discovery-fix-20201111

Conversation

@cmroche
Copy link
Copy Markdown
Contributor

@cmroche cmroche commented Nov 11, 2020

This fixes a bug with discovery for some devices which do not have a CID

See the release notes: https://github.com/cmroche/greeclimate/releases/tag/0.9.6

Proposed change

Some gree devices do not return a device id in the discovery response, this change addresses that issue by using the mac address field as the identifier in this case. This will fix issues with device discovery & binding on some models.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

This fixes a bug with discovery for some devices which do not have a CID
@probot-home-assistant probot-home-assistant Bot added bugfix dependency Pull requests marked as a dependency upgrade integration: gree small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file by-code-owner labels Nov 11, 2020
@cmroche
Copy link
Copy Markdown
Contributor Author

cmroche commented Nov 11, 2020

This change is a good candidate for the next bug fix release.

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 11, 2020

I've already cut the last patch release for this minor range. So this will go into the beta, that is pending for today.

@frenck frenck merged commit c93d290 into home-assistant:dev Nov 11, 2020
@cmroche
Copy link
Copy Markdown
Contributor Author

cmroche commented Nov 11, 2020

Thank you Frenck.

@cmroche cmroche deleted the gree-discovery-fix-20201111 branch November 11, 2020 18:49
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 11, 2020
* 'dev' of https://github.com/home-assistant/core: (552 commits)
  Use media player image proxy for roku media browser (home-assistant#43070)
  Add Shelly support for REST sensors (home-assistant#40429)
  Add system health section for the Supervisor (home-assistant#43074)
  Simplify distance conversion (home-assistant#43107)
  Add initial rest query params (home-assistant#42198)
  Bump pycsspeechtts to 1.0.4 (home-assistant#43105)
  Bump greeclimate to 0.9.6 (home-assistant#43106)
  Add reboot and shutdown service to synology_dsm (home-assistant#42697)
  Bump up ZHA dependencies (home-assistant#43104)
  Modify wait timeout in stream (home-assistant#42794)
  Bumped version to 0.117.6
  Fix Plex auth issues by setting header (home-assistant#43081)
  Bump gTTS-token to 1.1.4 (home-assistant#43015)
  Bump pwmled to v1.6.7 (home-assistant#42903)
  Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration (home-assistant#42804)
  Update frontend to 20201111.0 (home-assistant#43101)
  Show media progress in sisyphus (home-assistant#42996)
  Use internal url for Squeezebox if possible (home-assistant#43089)
  Add watchdog to reset nest subscriber (home-assistant#43034)
  Bump hatasmota to 0.0.29 (home-assistant#43013)
  ...
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade dependency-bump Pull requests that update a dependency file integration: gree small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to bind to gree device

3 participants