Skip to content

Modify wait timeout in stream#42794

Merged
Adminiuga merged 5 commits intohome-assistant:devfrom
uvjustin:modify-wait-before-restarting-stream
Nov 11, 2020
Merged

Modify wait timeout in stream#42794
Adminiuga merged 5 commits intohome-assistant:devfrom
uvjustin:modify-wait-before-restarting-stream

Conversation

@uvjustin
Copy link
Copy Markdown
Contributor

@uvjustin uvjustin commented Nov 3, 2020

Proposed change

There are some intermittent issues with the stream component which may be related to the stream restarting too quickly. This PR modifies the wait timeout used before attempting to restart the stream.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @hunterjm, mind taking a look at this pull request as its been labeled with an integration (stream) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@uvjustin uvjustin force-pushed the modify-wait-before-restarting-stream branch from ed18a6d to 435369c Compare November 5, 2020 08:49
@uvjustin uvjustin force-pushed the modify-wait-before-restarting-stream branch from 435369c to 4dd17d4 Compare November 6, 2020 08:42
@uvjustin uvjustin marked this pull request as ready for review November 6, 2020 10:31
Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adminiuga Adminiuga merged commit 66dccd8 into home-assistant:dev Nov 11, 2020
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 11, 2020
* 'dev' of https://github.com/home-assistant/core: (552 commits)
  Use media player image proxy for roku media browser (home-assistant#43070)
  Add Shelly support for REST sensors (home-assistant#40429)
  Add system health section for the Supervisor (home-assistant#43074)
  Simplify distance conversion (home-assistant#43107)
  Add initial rest query params (home-assistant#42198)
  Bump pycsspeechtts to 1.0.4 (home-assistant#43105)
  Bump greeclimate to 0.9.6 (home-assistant#43106)
  Add reboot and shutdown service to synology_dsm (home-assistant#42697)
  Bump up ZHA dependencies (home-assistant#43104)
  Modify wait timeout in stream (home-assistant#42794)
  Bumped version to 0.117.6
  Fix Plex auth issues by setting header (home-assistant#43081)
  Bump gTTS-token to 1.1.4 (home-assistant#43015)
  Bump pwmled to v1.6.7 (home-assistant#42903)
  Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration (home-assistant#42804)
  Update frontend to 20201111.0 (home-assistant#43101)
  Show media progress in sisyphus (home-assistant#42996)
  Use internal url for Squeezebox if possible (home-assistant#43089)
  Add watchdog to reset nest subscriber (home-assistant#43034)
  Bump hatasmota to 0.0.29 (home-assistant#43013)
  ...
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2020
@uvjustin uvjustin deleted the modify-wait-before-restarting-stream branch November 25, 2020 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants