Skip to content

Show media progress in sisyphus#42996

Merged
balloob merged 1 commit intohome-assistant:devfrom
jkeljo:sisyphus-progress
Nov 11, 2020
Merged

Show media progress in sisyphus#42996
balloob merged 1 commit intohome-assistant:devfrom
jkeljo:sisyphus-progress

Conversation

@jkeljo
Copy link
Copy Markdown
Contributor

@jkeljo jkeljo commented Nov 9, 2020

Proposed change

Adds support for media progress when communicating with a sisyphus table that supports it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

No changes required to existing configuration

Additional information

N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title sisyphus: support showing media progress Show media progress in sisyphus Nov 9, 2020
@MartinHjelmare MartinHjelmare marked this pull request as draft November 9, 2020 10:38
@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Nov 9, 2020

Converting to draft since this PR depends on another PR. Please rebase the branch on latest dev branch. Then remove draft.

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 10, 2020

The dependent PR has been merged, so this one needs a rebase

This is newly possible in recent Sisyphus table firmwares. If it doesn't work for you, make sure you're running at least firmware 1.10.73.
@jkeljo jkeljo marked this pull request as ready for review November 11, 2020 03:12
@balloob balloob merged commit 8f59104 into home-assistant:dev Nov 11, 2020
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 11, 2020
* 'dev' of https://github.com/home-assistant/core: (552 commits)
  Use media player image proxy for roku media browser (home-assistant#43070)
  Add Shelly support for REST sensors (home-assistant#40429)
  Add system health section for the Supervisor (home-assistant#43074)
  Simplify distance conversion (home-assistant#43107)
  Add initial rest query params (home-assistant#42198)
  Bump pycsspeechtts to 1.0.4 (home-assistant#43105)
  Bump greeclimate to 0.9.6 (home-assistant#43106)
  Add reboot and shutdown service to synology_dsm (home-assistant#42697)
  Bump up ZHA dependencies (home-assistant#43104)
  Modify wait timeout in stream (home-assistant#42794)
  Bumped version to 0.117.6
  Fix Plex auth issues by setting header (home-assistant#43081)
  Bump gTTS-token to 1.1.4 (home-assistant#43015)
  Bump pwmled to v1.6.7 (home-assistant#42903)
  Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration (home-assistant#42804)
  Update frontend to 20201111.0 (home-assistant#43101)
  Show media progress in sisyphus (home-assistant#42996)
  Use internal url for Squeezebox if possible (home-assistant#43089)
  Add watchdog to reset nest subscriber (home-assistant#43034)
  Bump hatasmota to 0.0.29 (home-assistant#43013)
  ...
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants