Skip to content

Apply media player image proxy updates to beta#43116

Closed
ctalkington wants to merge 1 commit intorcfrom
ctalkington-patch-rc-mp
Closed

Apply media player image proxy updates to beta#43116
ctalkington wants to merge 1 commit intorcfrom
ctalkington-patch-rc-mp

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented Nov 11, 2020

this missed the cutoff by a hair. made this against rc branch

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

this missed the cutoff by a hair
@probot-home-assistant probot-home-assistant Bot added core integration: media_player merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. labels Nov 11, 2020
@ctalkington ctalkington changed the title apply media player image proxy updates to beta Apply media player image proxy updates to beta Nov 11, 2020
@ctalkington ctalkington added this to the 0.118.0 milestone Nov 11, 2020
@ctalkington ctalkington marked this pull request as ready for review November 11, 2020 23:21
@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 12, 2020

Please do not target the rc branch, just use the dev branch as normal.

@ctalkington
Copy link
Copy Markdown
Contributor Author

@frenck these changes were already on dev though. they were fixed as part of #43070 so we could cherrypick that?

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 13, 2020
@pvizeli pvizeli deleted the ctalkington-patch-rc-mp branch January 4, 2021 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core integration: media_player merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants