Use internal url for Squeezebox if possible#43089
Merged
Conversation
probot-home-assistant
Bot
added
core
integration: squeezebox
new-feature
small-pr
frenck
approved these changes
Nov 11, 2020
balloob
changed the title
21 tasks
rajlaud
approved these changes
Nov 11, 2020
Contributor
|
Tested locally accessing HA through internal and external urls - works as expected. |
KJonline
pushed a commit
to Pyhass/core
that referenced
this pull request
Nov 11, 2020
* 'dev' of https://github.com/home-assistant/core: (552 commits) Use media player image proxy for roku media browser (home-assistant#43070) Add Shelly support for REST sensors (home-assistant#40429) Add system health section for the Supervisor (home-assistant#43074) Simplify distance conversion (home-assistant#43107) Add initial rest query params (home-assistant#42198) Bump pycsspeechtts to 1.0.4 (home-assistant#43105) Bump greeclimate to 0.9.6 (home-assistant#43106) Add reboot and shutdown service to synology_dsm (home-assistant#42697) Bump up ZHA dependencies (home-assistant#43104) Modify wait timeout in stream (home-assistant#42794) Bumped version to 0.117.6 Fix Plex auth issues by setting header (home-assistant#43081) Bump gTTS-token to 1.1.4 (home-assistant#43015) Bump pwmled to v1.6.7 (home-assistant#42903) Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration (home-assistant#42804) Update frontend to 20201111.0 (home-assistant#43101) Show media progress in sisyphus (home-assistant#42996) Use internal url for Squeezebox if possible (home-assistant#43089) Add watchdog to reset nest subscriber (home-assistant#43034) Bump hatasmota to 0.0.29 (home-assistant#43013) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use the internal url for Squeezebox if we're browsing Home Assistant on the local network.
CC @rajlaud
CC @frenck because I added a helper to
helpers/network.pyType of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: