Skip to content

Add Shelly support for REST sensors#40429

Merged
balloob merged 59 commits intohome-assistant:devfrom
chemelli74:chemelli74-rest-sensors
Nov 11, 2020
Merged

Add Shelly support for REST sensors#40429
balloob merged 59 commits intohome-assistant:devfrom
chemelli74:chemelli74-rest-sensors

Conversation

@chemelli74
Copy link
Copy Markdown
Contributor

@chemelli74 chemelli74 commented Sep 21, 2020 •
edited
Loading

Proposed change

Implemented REST sensors for values not available via CoAP

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added dependency Pull requests marked as a dependency upgrade integration: shelly new-feature labels Sep 21, 2020
@chemelli74 chemelli74 marked this pull request as draft September 21, 2020 20:43
@chemelli74
Copy link
Copy Markdown
Contributor Author

chemelli74 commented Sep 21, 2020

Waiting for a new aioshelly release with Implemented method for REST updates

I still need to learn a lot, so please let me know how to improve coding and even more important let me know what I did wrong.

Simone

@MartinHjelmare MartinHjelmare changed the title Added support for REST sensors Add support for REST sensors Sep 21, 2020
@MartinHjelmare MartinHjelmare changed the title Add support for REST sensors Add Shelly support for REST sensors Sep 21, 2020
bieniu
bieniu reviewed Sep 22, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/sensor.py Outdated
bieniu
bieniu reviewed Sep 22, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/sensor.py Outdated
bieniu
bieniu reviewed Sep 22, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/binary_sensor.py Outdated
bieniu
bieniu reviewed Sep 22, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/entity.py Outdated
@bieniu
Copy link
Copy Markdown
Member

bieniu commented Sep 22, 2020

We should use DataUpdateCoordinator to update status data. Currently, the sensor states aren't updated.

bieniu
bieniu reviewed Sep 22, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/binary_sensor.py Outdated
Misiu
Misiu reviewed Sep 22, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/sensor.py Outdated
@chemelli74 chemelli74 marked this pull request as ready for review September 25, 2020 16:18
balloob
balloob reviewed Sep 27, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/binary_sensor.py Outdated
balloob
balloob reviewed Sep 27, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/entity.py Outdated
balloob
balloob reviewed Sep 27, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/entity.py Outdated
balloob
balloob reviewed Sep 27, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/binary_sensor.py Outdated
balloob
balloob reviewed Sep 27, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/__init__.py Outdated
balloob
balloob reviewed Sep 27, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/entity.py Outdated
balloob
balloob reviewed Sep 27, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/entity.py Outdated
balloob
balloob reviewed Sep 27, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/entity.py Outdated
balloob
balloob reviewed Sep 28, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/entity.py Outdated
@chemelli74 chemelli74 requested a review from balloob November 7, 2020 19:45
bieniu
bieniu reviewed Nov 9, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/__init__.py Outdated
bieniu
bieniu reviewed Nov 9, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/__init__.py Outdated
bieniu
bieniu reviewed Nov 9, 2020
View reviewed changes
Comment thread homeassistant/components/shelly/__init__.py Outdated
@chemelli74
Cleanup leftover
5a42ba9
@chemelli74
Fix for sensors not updating
81f74d1
@chemelli74
Fix for sensors not updating #2
0a76498
@chemelli74
Implemented code suggestions
d76d2d1
@chemelli74
Added support for REST sensors
bcf87eb
@chemelli74
Added icon for Uptime aensor
73e2548
@chemelli74
RSSI disabled by default + REST sensors as part of main device
20489dc
@chemelli74
Removed icon when using DEVICE_CLASS
42f822a
@chemelli74
Cleanup leftover
15a73af
@chemelli74
Fix for sensors not updating
4c32f86
@chemelli74
Fix for sensors not updating #2
28f3f86
@chemelli74
Applied suggestions for firmware sensor
bc024f4
@chemelli74
Rebase and cleanup
ee19df9
@chemelli74
Added rest wrapper and refresh (thx to @bieniu)
e998dd5
@chemelli74
Moved parser func to utils
17b9516
@chemelli74
Param optimization
4624514
@chemelli74
Missing import
5c3dc69
@chemelli74
Applied suggestions
e80aafd
@chemelli74
Applied rename suggestion
1427dbf
@chemelli74
Moved REST update interval to const
73bd655
@chemelli74
Temporary excluding battery devices
f6ef3d1
@chemelli74
Apply code review suggestions
692bf0f
@chemelli74
Fix rebase errors
bf32003
@balloob balloob merged commit d8b067e into home-assistant:dev Nov 11, 2020
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 11, 2020
Merge branch 'dev' of https://github.com/home-assistant/core into dev
907fe3f 
* 'dev' of https://github.com/home-assistant/core: (552 commits)
  Use media player image proxy for roku media browser (home-assistant#43070)
  Add Shelly support for REST sensors (home-assistant#40429)
  Add system health section for the Supervisor (home-assistant#43074)
  Simplify distance conversion (home-assistant#43107)
  Add initial rest query params (home-assistant#42198)
  Bump pycsspeechtts to 1.0.4 (home-assistant#43105)
  Bump greeclimate to 0.9.6 (home-assistant#43106)
  Add reboot and shutdown service to synology_dsm (home-assistant#42697)
  Bump up ZHA dependencies (home-assistant#43104)
  Modify wait timeout in stream (home-assistant#42794)
  Bumped version to 0.117.6
  Fix Plex auth issues by setting header (home-assistant#43081)
  Bump gTTS-token to 1.1.4 (home-assistant#43015)
  Bump pwmled to v1.6.7 (home-assistant#42903)
  Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration (home-assistant#42804)
  Update frontend to 20201111.0 (home-assistant#43101)
  Show media progress in sisyphus (home-assistant#42996)
  Use internal url for Squeezebox if possible (home-assistant#43089)
  Add watchdog to reset nest subscriber (home-assistant#43034)
  Bump hatasmota to 0.0.29 (home-assistant#43013)
  ...
@chemelli74 chemelli74 deleted the chemelli74-rest-sensors branch November 11, 2020 22:28
thecode added a commit to thecode/core that referenced this pull request Nov 12, 2020
@thecode
Revert Shelly naming rebase errors
91549fd 
Revert mistakenly included “shelly_naming” function in PR home-assistant#40429 which was replaced by “get_entity_name”
Fix “get_entity_name” to support REST sensors
@thecode thecode mentioned this pull request Nov 12, 2020
Merged
21 tasks
rccoleman pushed a commit to rccoleman/core that referenced this pull request Dec 4, 2020
@chemelli74 @rccoleman
Add Shelly support for REST sensors (home-assistant#40429)
8476e7d
rccoleman pushed a commit to rccoleman/core that referenced this pull request Dec 4, 2020
@chemelli74 @rccoleman
Add Shelly support for REST sensors (home-assistant#40429)
d78df38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bieniu bieniu bieniu approved these changes

@balloob balloob balloob approved these changes

@thecode thecode thecode approved these changes

+1 more reviewer

@Misiu Misiu Misiu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@balloob balloob

Labels

cla-signed dependency Pull requests marked as a dependency upgrade integration: shelly new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chemelli74 @bieniu @balloob @Misiu @thecode @homeassistant