Skip to content

Fix Plex auth issues by setting header#43081

Merged
springstan merged 1 commit intohome-assistant:devfrom
jjlawren:plex_set_auth_header
Nov 11, 2020
Merged

Fix Plex auth issues by setting header#43081
springstan merged 1 commit intohome-assistant:devfrom
jjlawren:plex_set_auth_header

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Nov 11, 2020 •
edited by springstan
Loading

Proposed change

Plex recently added more validation on their auth flow to improve security. This caused our method to fail starting Nov 3rd.

This updates the library and adds the necessary header to allow new authorizations.
jjlawren/python-plexauth@v0.0.5...v0.0.6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added bugfix dependency Pull requests marked as a dependency upgrade integration: plex small-pr PRs with less than 30 lines. by-code-owner labels Nov 11, 2020
@jjlawren jjlawren added this to the 0.117.6 milestone Nov 11, 2020
springstan
springstan approved these changes Nov 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@springstan springstan merged commit 39cdf61 into home-assistant:dev Nov 11, 2020
@jjlawren jjlawren deleted the plex_set_auth_header branch November 11, 2020 14:54
frenck pushed a commit that referenced this pull request Nov 11, 2020
@jjlawren @frenck
Fix Plex auth issues by setting header (#43081)
176c2f3
@frenck frenck mentioned this pull request Nov 11, 2020
Merged
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 11, 2020
Merge branch 'dev' of https://github.com/home-assistant/core into dev
907fe3f 
* 'dev' of https://github.com/home-assistant/core: (552 commits)
  Use media player image proxy for roku media browser (home-assistant#43070)
  Add Shelly support for REST sensors (home-assistant#40429)
  Add system health section for the Supervisor (home-assistant#43074)
  Simplify distance conversion (home-assistant#43107)
  Add initial rest query params (home-assistant#42198)
  Bump pycsspeechtts to 1.0.4 (home-assistant#43105)
  Bump greeclimate to 0.9.6 (home-assistant#43106)
  Add reboot and shutdown service to synology_dsm (home-assistant#42697)
  Bump up ZHA dependencies (home-assistant#43104)
  Modify wait timeout in stream (home-assistant#42794)
  Bumped version to 0.117.6
  Fix Plex auth issues by setting header (home-assistant#43081)
  Bump gTTS-token to 1.1.4 (home-assistant#43015)
  Bump pwmled to v1.6.7 (home-assistant#42903)
  Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration (home-assistant#42804)
  Update frontend to 20201111.0 (home-assistant#43101)
  Show media progress in sisyphus (home-assistant#42996)
  Use internal url for Squeezebox if possible (home-assistant#43089)
  Add watchdog to reset nest subscriber (home-assistant#43034)
  Bump hatasmota to 0.0.29 (home-assistant#43013)
  ...
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@springstan springstan springstan approved these changes

Assignees

No one assigned

Labels

bugfix by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: plex small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.117.6

Development

Successfully merging this pull request may close these issues.

Plex integration failure using Obtain a new token from plex.tv method Plex Integration not working correct

4 participants

@jjlawren @springstan @frenck @homeassistant