Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration#42804
Merged
springstan merged 2 commits intohome-assistant:devfrom Nov 6, 2020
soldag:dev
Merged
Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration#42804springstan merged 2 commits intohome-assistant:devfrom soldag:dev
springstan merged 2 commits intohome-assistant:devfrom
soldag:dev
Conversation
springstan
approved these changes
Nov 5, 2020
Member
springstan
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding yourself as codeowner 🎉
Member
|
@soldag should we tag this for |
Contributor
Author
|
@springstan yes, sounds good 👍 |
Member
@soldag Tagging this for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently the integration updates the state of the physical device on startup of HASS. This is not only bad as it does I/O on the event loop, but is also no longer necessary at all with latest version of the used lib for controlling the lights.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: