Skip to content

Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration#42804

Merged
springstan merged 2 commits intohome-assistant:devfrom
soldag:dev
Nov 6, 2020
Merged

Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration#42804
springstan merged 2 commits intohome-assistant:devfrom
soldag:dev

Conversation

@soldag
Copy link
Copy Markdown
Contributor

@soldag soldag commented Nov 3, 2020

Proposed change

Currently the integration updates the state of the physical device on startup of HASS. This is not only bad as it does I/O on the event loop, but is also no longer necessary at all with latest version of the used lib for controlling the lights.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding yourself as codeowner 🎉

@springstan
Copy link
Copy Markdown
Member

@soldag should we tag this for 0.117.5 as the upstream bump has been merged in 0.117.4 and this PR completes this version bump?

@soldag
Copy link
Copy Markdown
Contributor Author

soldag commented Nov 6, 2020

@springstan yes, sounds good 👍

@springstan
Copy link
Copy Markdown
Member

springstan commented Nov 6, 2020

@springstan yes, sounds good 👍

0.117.5 has been merged in the meantime and I think that no more patch release will come before the next major version.
Therefore, I think this will have to wait for 0.118.

@soldag Tagging this for 0.117.6 so this can be released as fast as possible.

@springstan springstan merged commit 4e614e0 into home-assistant:dev Nov 6, 2020
@springstan springstan added this to the 0.117.6 milestone Nov 7, 2020
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants