Add initial rest query params#42198
Add initial rest query params#42198bdraco merged 12 commits intohome-assistant:devfrom boxcee:rest-query-params
Conversation
| CONF_OFFSET = "offset" | ||
| CONF_OPTIMISTIC = "optimistic" | ||
| CONF_PACKAGES = "packages" | ||
| CONF_PARAMS = "params" |
There was a problem hiding this comment.
Should be parameters.
| CONF_PARAMS = "params" | |
| CONF_PARAMETERS = "parameters" |
There was a problem hiding this comment.
Naming is directly taken from httpx. requests uses the same naming.
|
@bdraco Added the link to the documentation PR in the description. |
bdraco
left a comment
There was a problem hiding this comment.
LGTM.
I'm going to defer merging in case fabaff feels strongly about the naming.
|
Hey @fabaff, can you double-check? |
|
The three above all use Really looking forward to this feature. Right now I cannot use secrets in query parameters. Please, take decision: @bdraco, @MartinHjelmare, @fabaff. |
|
Please do not ping reviewers. There is a significant backlog of PRs to review, and working though additional notifications only slows things down. |
* 'dev' of https://github.com/home-assistant/core: (552 commits) Use media player image proxy for roku media browser (home-assistant#43070) Add Shelly support for REST sensors (home-assistant#40429) Add system health section for the Supervisor (home-assistant#43074) Simplify distance conversion (home-assistant#43107) Add initial rest query params (home-assistant#42198) Bump pycsspeechtts to 1.0.4 (home-assistant#43105) Bump greeclimate to 0.9.6 (home-assistant#43106) Add reboot and shutdown service to synology_dsm (home-assistant#42697) Bump up ZHA dependencies (home-assistant#43104) Modify wait timeout in stream (home-assistant#42794) Bumped version to 0.117.6 Fix Plex auth issues by setting header (home-assistant#43081) Bump gTTS-token to 1.1.4 (home-assistant#43015) Bump pwmled to v1.6.7 (home-assistant#42903) Remove unneeded state restoration of the physical device in rpi_gpio_pwm integration (home-assistant#42804) Update frontend to 20201111.0 (home-assistant#43101) Show media progress in sisyphus (home-assistant#42996) Use internal url for Squeezebox if possible (home-assistant#43089) Add watchdog to reset nest subscriber (home-assistant#43034) Bump hatasmota to 0.0.29 (home-assistant#43013) ...
* add initial rest query params * of course I didn't run black * fix tests * fix tests * add test * reformat * add binary sensor test * fix tests * add one more test and fix switch * should not have touched that * if you don't pay attention once
* add initial rest query params * of course I didn't run black * fix tests * fix tests * add test * reformat * add binary sensor test * fix tests * add one more test and fix switch * should not have touched that * if you don't pay attention once
Breaking change
Proposed change
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: