Skip to content

Add query params for REST sensors#38482

Closed
boxcee wants to merge 1 commit intohome-assistant:devfrom
boxcee:use-query-params
Closed

Add query params for REST sensors#38482
boxcee wants to merge 1 commit intohome-assistant:devfrom
boxcee:use-query-params

Conversation

@boxcee
Copy link
Copy Markdown
Contributor

@boxcee boxcee commented Aug 2, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

sensor:
- platform: rest
  resource_template: 'https://revgeocode.search.hereapi.com/v1/revgeocode'
  params:
    at: '52.521,13.3807'
    lang: 'en-GB'
    apiKey: !secret apiKey
  value_template: '{{ value_json["items"][0]["address"]["district"] }}'

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @fabaff, mind taking a look at this pull request as its been labeled with an integration (pvoutput) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@boxcee boxcee marked this pull request as ready for review August 2, 2020 18:36
@MartinHjelmare MartinHjelmare changed the title Add query params for REST sensors. Add query params for REST sensors Aug 5, 2020
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add a test

@stale
Copy link
Copy Markdown

stale Bot commented Sep 5, 2020

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale Bot added the stale label Sep 5, 2020
@stale stale Bot closed this Sep 12, 2020
@boxcee
Copy link
Copy Markdown
Contributor Author

boxcee commented Oct 21, 2020

/reopen

@boxcee
Copy link
Copy Markdown
Contributor Author

boxcee commented Oct 22, 2020

Attempted it again: #42198

hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants