Skip to content

Implemented method for REST updates#16

Merged
chemelli74 merged 6 commits intohome-assistant-libs:mainfrom
chemelli74:chemelli74-status
Sep 19, 2020
Merged

Implemented method for REST updates#16
chemelli74 merged 6 commits intohome-assistant-libs:mainfrom
chemelli74:chemelli74-status

Conversation

@chemelli74
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need update settings and status at a time? status will be updated periodically, settings on init only.

@chemelli74
Copy link
Copy Markdown
Collaborator Author

Do we need update settings and status at a time? status will be updated periodically, settings on init only.

Settings can be changed as well, not as frequently as status but still.

@bieniu
Copy link
Copy Markdown
Collaborator

bieniu commented Sep 19, 2020

But we only use data from settings during init. I think we need the update_status method, and if we ever need to update the settings, we will add the update_settings method.

@chemelli74
Copy link
Copy Markdown
Collaborator Author

But we only use data from settings during init. I think we need the update_status method, and if we ever need to update the settings, we will add the update_settings method.

Done.
We can also consider using "cfg_changed_cnt" from status to know if a call to update settings is needed or not.

@bieniu
Copy link
Copy Markdown
Collaborator

bieniu commented Sep 19, 2020

That's a good idea. We have to consider whether we are interested in changing the device configuration during HA operation.

@chemelli74
Copy link
Copy Markdown
Collaborator Author

That's a good idea. We have to consider whether we are interested in changing the device configuration during HA operation.

Let's keep it for a later use, if needed.

@chemelli74 chemelli74 merged commit af4b5c3 into home-assistant-libs:main Sep 19, 2020
@balloob
Copy link
Copy Markdown
Contributor

balloob commented Sep 19, 2020

Would be cool if we would automatically update settings if status contains a new config count. We should in that case rename the function name, as it's not just status that is being updated.

@chemelli74 chemelli74 deleted the chemelli74-status branch September 23, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants