Atome by BaQs · Pull Request #26044 · home-assistant/core

BaQs · 2019-08-18T13:21:57Z

Breaking Change:

Description:

The atome sensor platform is retrieving the consumption of your home from the Direct Energy Atome electric meter.
This special little device is connected to a Linky Electric Meter, and sends live data to a cloud platform.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
10172: home-assistant/home-assistant.io#10172

Example entry for `configuration.yaml` (if applicable):

sensor:
  - platform: atome
    username: YOUR_ATOME_USERNAME
    password: YOUR_ATOME_PASSWORD

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

* Expose comfort presets as HA presets * Fix bugs * Handle unavailable * log level debug on update * Lint

* Improve handling of empty results from Rejseplanen (Fixes #25566) * Exclude attributes with null value * Add period back into docstring * Fix formatting

)

* Improve log error messages * remove unique_id not ready yet

* Initial commit * Add some more code * Local tests passing * Remove unnecessary line * Add preset attributes to __init__ * Remove some more debugger lines * Add some tests * Fix comparision to None * Improve test coverage * Use unknown modes as presets * Bugfixes and test improvements * Add tests for unknown preset modes * linting * Improve mappings * Move PRESET_MANUFACTURER_SPECIFIC to zwave * Replace isinstance with cast * Add test for hvac_action * hvac_mode is never None * Improved mapping of current mode to hvac/preset modes * Fix bugs where hvac_mode is None * Add default hvac mode * Fixed default hvac mode * Fix linting * Make flake happy * Another linting * Make black happy * Complete list of default hvac modes * Add mapping to heat/cool eco * Fixed another bug where mapping goes wrong

* enable climate away_mode and home.refresh * Add Party eco modes

* Allow configuration to not track clients or devices

* Revert Black * Revert "Introduce support for color temperature (#25503)" This reverts commit e1d884a. * Revert "Fix flux_led only-white controllers (#22210)" This reverts commit 4813818. * Revert "Fix MagicHome LEDs with flux_led component (#20733)" This reverts commit 1444a68. * Re-Black * Use mode detection for scanned bulbs

* Fix issue with incorrect Notion bridge IDs * Less aggressive * Member comments

* Make connectivity control in line with other implementations

* Add HmIP-SCI to Homematic IP Cloud * Bump upstream dependency * Fix HmIP-SWDM

* Bump envoy_reader to 0.8.6, fix missing dependency * Bump envoy_reader to 0.8.6, fix missing dependency

* Allow reloading scenes * Update requirements * address comments * fix typing * fix tests * Update homeassistant/components/homeassistant/scene.py Co-Authored-By: Martin Hjelmare <marhje52@kth.se> * Address comments

* Update HTTP defaults * Fix tests

* Handle device not having a name

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

MartinHjelmare · 2019-08-25T11:13:04Z

You can do an interactive git rebase. If you're not comfortable with git it might be easier to start over in a new branch and PR.

…tome

BaQs · 2019-08-25T11:15:19Z

You can do an interactive git rebase. If you're not comfortable with git it might be easier to start over in a new branch and PR.

I just tried rebasing, I don't think this is better, right ?
( if it's the case I'll do a new PR indeed, sorry for that)

MartinHjelmare · 2019-08-25T11:17:49Z

Just git rebase won't do the trick. You need to specify the commits to remove or keep somehow. One way of doing this is with the -i switch, to enter interactive mode. But please read up on git rebase before doing this.

BaQs · 2019-08-25T11:52:46Z

Ok here is the clean PR:
#26197

balloob and others added 30 commits July 31, 2019 16:19

Bump version to 0.97.0b0

207cf18

Expose comfort presets as HA presets (#25491)

59b42b4

* Expose comfort presets as HA presets * Fix bugs * Handle unavailable * log level debug on update * Lint

Fix handling of empty results from Rejseplanen (#25610)

d3f6c43

* Improve handling of empty results from Rejseplanen (Fixes #25566) * Exclude attributes with null value * Add period back into docstring * Fix formatting

bump quirks (#25618)

7168dd6

Handle disabled devices (#25625)

56ca0ed

Fix polling HomeKit devices with multiple services per accessory (#25629

414b85c

)

Meteofrance improve log error messages (#25630)

725d5c6

* Improve log error messages * remove unique_id not ready yet

Bump homekit_python to 0.15 (#25631)

1d5709f

Filter out empty results in history API (#25633)

476a727

Upgrade hass-nabucasa to 0.16 (#25636)

a8c4fc3

Updated frontend to 20190801.0

d64730a

Bumped version to 0.97.0b1

ad341e2

Updated frontend to 20190804.0

949875a

Add PRESET_AWAY to HomematicIP Cloud climate (#25641)

e001b12

* enable climate away_mode and home.refresh * Add Party eco modes

UniFi - allow configuration to not track clients or devices (#25642)

b40d324

* Allow configuration to not track clients or devices

Add preset to be away and eco (#25643)

d95c86e

Options to not track wired clients (#25669)

7a71669

Fix issue with incorrect Notion bridge IDs (#25683)

f8753a0

* Fix issue with incorrect Notion bridge IDs * Less aggressive * Member comments

In some circumstances device.last_seen can be None (#25690)

2925f9e

UniFi - reverse connectivity logic (#25691)

4e2094c

* Make connectivity control in line with other implementations

Fix roku lxml requirement (#25696)

868c6f4

Bumped version to 0.97.0b2

6e61b21

Updated frontend to 20190805.0

387323a

Add HmIP-SCI to Homematic IP Cloud, Fix HmIP-SWDM (#25639)

e1c23b1

* Add HmIP-SCI to Homematic IP Cloud * Bump upstream dependency * Fix HmIP-SWDM

Bump envoy_reader to 0.8.6, fix missing dependency (#25679)

b011dd0

* Bump envoy_reader to 0.8.6, fix missing dependency * Bump envoy_reader to 0.8.6, fix missing dependency

Add service to reload scenes from configuration.yaml (#25680)

eceef82

* Allow reloading scenes * Update requirements * address comments * fix typing * fix tests * Update homeassistant/components/homeassistant/scene.py Co-Authored-By: Martin Hjelmare <marhje52@kth.se> * Address comments

Update HTTP defaults (#25702)

fee1568

* Update HTTP defaults * Fix tests

UniFi - handle device not having a name (#25713)

27cfda1

* Handle device not having a name

BaQs and others added 20 commits August 25, 2019 13:02

First line should be in imperative mood

45acde4

flake8 stupidity...

6fa4c7c

Flake8 fixes

55f06d2

Just a test

7b04dc7

Export external calls to PyAtome pypi package

0dd3594

Export external calls to PyAtome pypi package

0cece00

Export external calls to PyAtome pypi package

c1c15c6

Export external calls to PyAtome pypi package

891d2fd

Export external calls to PyAtome pypi package

d91b0ec

Export external calls to PyAtome pypi package

2f2f8ea

Wrong get data function

debccfa

Do not deserver yet to be code owner

737fc7d

Added proper codeowner

7b2ccb0

Added pyatome requirement for Atome new platform

816ae49

Black reformatted

fb7851a

Update .coveragerc

57639b0

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

first commit of atome component

8150a64

Logging

1b610e3

Proper exception handling, now need pyatome 0.0.15

aa48a72

Requirement

747ba8f

Merge branch 'atome' of https://github.com/baqs/home-assistant into a…

1cc886a

…tome

BaQs requested review from bachya and robbiet480 as code owners August 25, 2019 11:14

BaQs closed this Aug 25, 2019

BaQs deleted the atome branch August 25, 2019 12:07

lock Bot locked and limited conversation to collaborators Aug 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Atome#26044

Atome#26044
BaQs wants to merge 219 commits into
home-assistant:devfrom
BaQs:atome

BaQs commented Aug 18, 2019

Uh oh!

MartinHjelmare commented Aug 25, 2019

Uh oh!

BaQs commented Aug 25, 2019

Uh oh!

MartinHjelmare commented Aug 25, 2019

Uh oh!

BaQs commented Aug 25, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

BaQs commented Aug 18, 2019

Breaking Change:

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

MartinHjelmare commented Aug 25, 2019

Uh oh!

BaQs commented Aug 25, 2019

Uh oh!

MartinHjelmare commented Aug 25, 2019

Uh oh!

BaQs commented Aug 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Example entry for `configuration.yaml` (if applicable):

BaQs commented Aug 25, 2019 •

edited

Loading