Skip to content

Revert flux_led to 0.89#25653

Merged
pvizeli merged 6 commits into
home-assistant:devfrom
amelchio:revert-flux_led
Aug 2, 2019
Merged

Revert flux_led to 0.89#25653
pvizeli merged 6 commits into
home-assistant:devfrom
amelchio:revert-flux_led

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

@amelchio amelchio commented Aug 2, 2019

Description:

This reverts three previous flux_led PRs:

The reverts bring flux_led back to the 0.89 level, as suggested in #22161 (comment). This includes the bug that #20733 tried to fix but I think it has become clear that it must be fixed in a different way.

I kept in a single fix that seems unrelated, #22161 (comment).

The commits cross both Black and The Great Migration so this does not exactly match the original PRs.

Related issue (if applicable): fixes #23322

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@amelchio amelchio added this to the 0.97.0 milestone Aug 2, 2019
@pvizeli pvizeli merged commit 2f7c57b into home-assistant:dev Aug 2, 2019
@lock lock Bot locked and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flux/MagicHome Issues Setting RGB and RGBW (Color plus Whitelevel)

4 participants