Fix issue with incorrect Notion bridge IDs#25683
Merged
Merged
Conversation
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Do we need to update _update_bridge_id?
Does the entity continue to operate without a valid bridge id? Should the entity be marked unavailable when this happens?
Contributor
Author
Great call!
The sensors will continue to work perfectly, interestingly – ran for several hours last night and everything works as expected. Makes me think this is just an API issue, not an underlying problem. |
balloob
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Fix issue with incorrect Notion bridge IDs * Less aggressive * Member comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A new bug popped into the Notion API: it's possible for sensors to refer to bridge IDs that don't actually exist. Currently, this throws an exception (because each entity's
device_infoexpects this info to be valid) and prevents that sensor from loading. This PR ensures that sensors continue to load even if they refer to a nonexistent bridge.Related issue (if applicable): fixes #25682
Pull request with documentation for home-assistant.io (if applicable): N/A
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass