Skip to content

UniFi - allow configuration to not track clients or devices#25642

Merged
Kane610 merged 3 commits into
home-assistant:devfrom
Kane610:unifi-device-tracker-track-booleans
Aug 2, 2019
Merged

UniFi - allow configuration to not track clients or devices#25642
Kane610 merged 3 commits into
home-assistant:devfrom
Kane610:unifi-device-tracker-track-booleans

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Aug 1, 2019

Breaking Change:

Description:

Related issue (if applicable): fixes #25638

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10034

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/unifi/controller.py Outdated
Comment thread homeassistant/components/unifi/controller.py Outdated
Comment thread tests/components/unifi/test_device_tracker.py Outdated
Comment thread tests/components/unifi/test_device_tracker.py Outdated
@Kane610 Kane610 merged commit 3925716 into home-assistant:dev Aug 2, 2019
@Kane610 Kane610 deleted the unifi-device-tracker-track-booleans branch August 2, 2019 08:13
@MartinHjelmare
Copy link
Copy Markdown
Member

Please let the reviewer approve before merging.

@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Aug 2, 2019

I apologize that was unnecessarily rushed of me. It will not happen again

@lock lock Bot locked and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UniFi controller integration - can't disable tracking

5 participants