Filter out empty results in history API#25633
Merged
Merged
Conversation
probot-home-assistant
Bot
added
core
has-tests
integration: history
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
andrewsayre
approved these changes
Aug 1, 2019
| assert response.status == 200 | ||
|
|
||
|
|
||
| async def test_fetch_period_api_with_include_order(hass, hass_client): |
Member
There was a problem hiding this comment.
Just to confirm - this is a test for something else, right? not the introduced functionality? I don't see it validating the results, other than HTTP status.
Member
Author
There was a problem hiding this comment.
The request failed before my fix, because it assumed each entry for an entity had at least 1 state. It does indeed not validate the results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Make sure that the history results never contain an empty state set for an entity.
CC @thomasloven
Related issue (if applicable): fixes issue reported by @VDRainer
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: