Skip to content

Meteofrance improve log error messages#25630

Merged
balloob merged 2 commits into
home-assistant:devfrom
oncleben31:meteofrance-improve
Aug 1, 2019
Merged

Meteofrance improve log error messages#25630
balloob merged 2 commits into
home-assistant:devfrom
oncleben31:meteofrance-improve

Conversation

@oncleben31
Copy link
Copy Markdown
Contributor

Breaking Change:

N/A

Description: Improve log error and debug messages to help understand unexpected errors.

Related issue (if applicable): fixes partially #25513

**Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost
Copy link
Copy Markdown

ghost commented Aug 1, 2019

Hey there @victorcerutti, mind taking a look at this pull request as its been labeled with a integration (meteo_france) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob added this to the 0.97.0 milestone Aug 1, 2019
@balloob balloob merged commit f7a47c6 into home-assistant:dev Aug 1, 2019
@oncleben31 oncleben31 deleted the meteofrance-improve branch August 1, 2019 20:31
balloob pushed a commit that referenced this pull request Aug 1, 2019
* Improve log error messages

* remove unique_id not ready yet
@lock lock Bot locked and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants