Skip to content

Add atome sensor platform#26197

Merged
MartinHjelmare merged 12 commits into
home-assistant:devfrom
BaQs:platform/atome
Sep 4, 2019
Merged

Add atome sensor platform#26197
MartinHjelmare merged 12 commits into
home-assistant:devfrom
BaQs:platform/atome

Conversation

@BaQs
Copy link
Copy Markdown
Contributor

@BaQs BaQs commented Aug 25, 2019

Breaking Change:

Description:

The atome sensor platform is retrieving the consumption of your home from the Direct Energy Atome electric meter.
This special little device is connected to a Linky Electric Meter, and sends live data to a cloud platform.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable):
home-assistant/home-assistant.io#10172

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: atome
    username: YOUR_ATOME_USERNAME
    password: YOUR_ATOME_PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@BaQs BaQs marked this pull request as ready for review August 25, 2019 15:09
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py
Comment thread homeassistant/components/atome/sensor.py Outdated
@MartinHjelmare MartinHjelmare changed the title Platform/atome Add atome sensor platform Aug 26, 2019
Comment thread homeassistant/components/atome/sensor.py
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small fixes left.

Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
Comment thread homeassistant/components/atome/sensor.py Outdated
@BaQs
Copy link
Copy Markdown
Contributor Author

BaQs commented Sep 4, 2019

Please do not hesitate if you think anything should be improved.
Thx for your reviews, your advices, and your time!

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 6acfede into home-assistant:dev Sep 4, 2019
pgilad added a commit to pgilad/home-assistant that referenced this pull request Sep 4, 2019
* dev: (87 commits)
  Add atome sensor platform (home-assistant#26197)
  Replaces IOError by OSError (home-assistant#26428)
  Entity registry doesn't overwrite with None (home-assistant#24275)
  Add device to mqtt camera (home-assistant#26238)
  Updated frontend to 20190904.0 (home-assistant#26421)
  Add prettier to vscode (home-assistant#26417)
  NSW Rural Fire Service icon for geolocation entities (home-assistant#26416)
  Update azure-pipelines-translation.yml for Azure Pipelines
  [ci skip] Translation update
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Bumped version to 0.98.3
  Bump ISY994's PyISY dependency to 1.1.2 (home-assistant#26413)
  Fix state report (home-assistant#26406)
  Update to 0.1.13 (home-assistant#26402)
  Met, check for existing location (home-assistant#26400)
  Allow core config updated (home-assistant#26398)
  Fix race during initial Sonos group construction (home-assistant#26371)
  ...
@lock lock Bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants