Skip to content

UniFi - reverse connectivity logic#25691

Merged
Kane610 merged 2 commits into
home-assistant:devfrom
Kane610:unifi-revert-block-switch-logic
Aug 4, 2019
Merged

UniFi - reverse connectivity logic#25691
Kane610 merged 2 commits into
home-assistant:devfrom
Kane610:unifi-revert-block-switch-logic

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Aug 4, 2019

Breaking Change:

Description:

@arsaboo pointed out inconsistencies with other definitions of connectivity in HASS. So I'm reversing the logic. This also puts it inline with how the POE switch represents on/off state in component.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 added this to the 0.97.0 milestone Aug 4, 2019
@Kane610 Kane610 self-assigned this Aug 4, 2019
@probot-home-assistant probot-home-assistant Bot added the small-pr PRs with less than 30 lines. label Aug 4, 2019
@Kane610 Kane610 merged commit 5762917 into home-assistant:dev Aug 4, 2019
@Kane610 Kane610 deleted the unifi-revert-block-switch-logic branch August 4, 2019 14:57
balloob pushed a commit that referenced this pull request Aug 5, 2019
* Make connectivity control in line with other implementations
@lock lock Bot locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants