Fix polling HomeKit devices with multiple services per accessory#25629
Merged
Conversation
Member
Author
|
Can this be go in 0.97.0 too as its a regression. |
MartinHjelmare
approved these changes
Aug 1, 2019
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
While testing the new beta to see if #25249 helped with scaling and stability issues with many homekit entities @niemyjski reported seeing this traceback:
HomeKit accessories are made up of Accessories, Services and Characteristics. Most of the devices i work with are either a single accessory with a single service or for a bridge like Hue, many accessories each with a single service. But there are also devices with many accessories and many services and also 1 accessory with many services. Sensors often have CO2, temperature and humidity as a single accessory with multiple services.
The code in #25249 didn't adequately consider these devices and failed when encountering a characteristic from another service on the same accessory. This PR handles that case.
Checklist:
tox. Your PR cannot be merged unless tests pass