Skip to content

Add Nest preset that is both away and eco#25643

Merged
andrewsayre merged 1 commit into
devfrom
nest-eco-and-away
Aug 1, 2019
Merged

Add Nest preset that is both away and eco#25643
andrewsayre merged 1 commit into
devfrom
nest-eco-and-away

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Aug 1, 2019

Description:

Add a new preset for Nest to be away and in eco mode.

Related issue (if applicable): fixes #25427

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@balloob balloob added this to the 0.97.0 milestone Aug 1, 2019
@balloob balloob requested a review from awarecan as a code owner August 1, 2019 22:28
@probot-home-assistant probot-home-assistant Bot added integration: nest small-pr PRs with less than 30 lines. labels Aug 1, 2019
@ghost ghost assigned awarecan Aug 1, 2019
@ghost
Copy link
Copy Markdown

ghost commented Aug 1, 2019

Hey there @awarecan, mind taking a look at this pull request as its been labeled with a integration (nest) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob changed the title Add preset to be away and eco Add Nest preset that is both away and eco Aug 1, 2019
Copy link
Copy Markdown
Member

@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems hacky, but it works and fits our schema.

@andrewsayre andrewsayre merged commit b5e2962 into dev Aug 1, 2019
@delete-merged-branch delete-merged-branch Bot deleted the nest-eco-and-away branch August 1, 2019 23:32
@lock lock Bot locked and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nest - No longer able to differentiate Home/Away from Eco

4 participants