Skip to content

Add PRESET_AWAY to HomematicIP Cloud climate#25641

Merged
pvizeli merged 2 commits into
home-assistant:devfrom
SukramJ:hmip-away
Aug 3, 2019
Merged

Add PRESET_AWAY to HomematicIP Cloud climate#25641
pvizeli merged 2 commits into
home-assistant:devfrom
SukramJ:hmip-away

Conversation

@SukramJ
Copy link
Copy Markdown
Contributor

@SukramJ SukramJ commented Aug 1, 2019

Description:

Add PRESET_AWAY to HomematicIP Cloud.
Vacation can be set by a call service (homematicip_cloud.activate_vacation), and will now displayed by the individual climate entity.

This PR fixes also the missing refresh for HOME.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

Comment thread homeassistant/components/homematicip_cloud/climate.py
@SukramJ SukramJ changed the title Add PRESET_AWAY to HomematicIP Cloud Add PRESET_AWAY to HomematicIP Cloud climate Aug 3, 2019
@pvizeli pvizeli added this to the 0.97.0 milestone Aug 3, 2019
@pvizeli pvizeli merged commit 73f5575 into home-assistant:dev Aug 3, 2019
@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Aug 3, 2019

Hi @pvizeli, @balloob,
if you want to add this PR to milestone 0.97, then you need to add also #25639 to the milestone.
Otherwise a device (HmIP-SWDM) will be lost due to a reorg in the upstream lib. It is also a small PR.
BR

@SukramJ SukramJ deleted the hmip-away branch August 3, 2019 19:48
@lock lock Bot locked and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants