Fixing nav order... again #82377
Closed
Fixing nav order... again #82377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#80198) (elastic#80322) * Added component to truncate text programmatically and add tooltips. Changed all field text values to use this component. * Fixed build failures. * Switched from FC component to one without children Co-authored-by: Paul Tavares <[email protected]> * Added some docs for the shared component. * Updated snapshots. Co-authored-by: Paul Tavares <[email protected]> Co-authored-by: Paul Tavares <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
…eld (elastic#80001) (elastic#80332) * Correct the Name field label on the Trusted Apps Create form to say "Name your trusted application" (was "Name your trusted app application").
* fixes to make grid layout a bit more solid. * Changed the spacing a bit more. * Updated snapshot.
(cherry picked from commit 4f4abf2)
…LICY_CHANGE action (elastic#80081) (elastic#80330)
…#80318) * [ILM] Cloud-specific changes for 7.10 (elastic#79650) * added cloud cold tier specific call out, probably wip * added jest test * rephrase copy * Added logic for showing/hiding data tier allocation option - Added server-side test for detecting legacy config - Added client-side test for asserting on cloud data tier option is hidden * added test for not-on-cloud case * Refactored logic for rendering data allocation notices Also updated a comment. * paraphrashing of Adams copy recommendation * Fix comment * address pr feedback * clarify slight hack comment * complete refactor of new flag for tests Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/index_lifecycle_management/server/routes/api/nodes/register_list_route.ts * replace r with (r)
…0353) Co-authored-by: Kibana Machine <[email protected]>
* [ML] add swim lane styles for dark theme * [ML] fix global time range update on sell selection * [ML] fix getSelectionTimeRange * [ML] fix range selection for embeddable * [ML] fix job selection * [ML] fix swim lane limit
…stic#80366) * try catch the buildEsQuery * add test
…80354) (elastic#80378) Co-authored-by: spalger <[email protected]>
…lastic#80376) * Add loading spinner to EQL Query Bar This gives the user some indication that the validation is being performed in the background, and that their query's validity is currently undefined. * Preserve whitespace on display of rule queries This is useful for all rules, but particularly for EQL rules, where sequences will be multiline. * Fix tests around query description This content is now wrapped in a whitespace-preserving element, so these need to be updated ever so slightly. * Update cypress assertions around rule queries * Remove extra space from assertion * This extra space was removed in the presentation component. I didn't find an explicit reason why it was there in the first place. * Use have.value when asserting on form inputs
… and xpack.ingestManager.agents (elastic#80394) (elastic#80413)
…rades (elastic#80391) (elastic#80421) * filter out non-upgradeable agents when user bulk upgrades * check for unenrolled or unenrolling agents in isAgentUpgradeable
… bug with query preview + tests (elastic#80110) (elastic#80425) ## Summary This PR is meant to address the remaining rule query preview bugs. It addresses the following: - gives same loading experience for all rule query types (previously there were two different loading states) - makes sure noise warnings are showing for all query types and disappear on timeframe or query change - updates when to/from are set so it is set on preview click
When `add`ing an element with an already existing ID, it will use the already existing data instead of setting new data. This made it so when you change the time picker the element health statuses would not update. When we get new elements, replace the existing data for existing elements. Fixes elastic#80335.
…0349) (elastic#80457) This PR stabilizes the functional calendar tests, which are flaky on cloud.
…elastic#80317) (elastic#80466) * [ML] Fix Anomaly Explorer charts time range to obey time picker range * [ML] Fix explorer_charts_container_service Jest tests
… tests (elastic#80224) (elastic#80401) * Enabled Trusted Apps functional tests * Additional Trusted App Functional Tests * Updated Jest snapshots
…ta gird. (elastic#80467) (elastic#80494) - Fix for color coding for outlier detection due to updated feature influence format. - Fix for displaying cell values for nested fields.
…) (elastic#80502) ## Summary fixes elastic#80136 Haven't added/updated tests yet but tested the various combinations in the UI and all worked as expected. <details><summary>Screenshots</summary> <h3>Policy listing</h3> <img width="1302" alt="Screen Shot 2020-10-14 at 7 05 19 AM" src="https://user-images.githubusercontent.com/57655/95981056-1c1c6d00-0dec-11eb-9746-5e91043f3d19.png"> <h3>Update existing policy succeeds</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 05 49 AM" src="https://user-images.githubusercontent.com/57655/95981059-1cb50380-0dec-11eb-9e55-7a14b72085f9.png"> <h3>Creating new policy w/existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 06 06 AM" src="https://user-images.githubusercontent.com/57655/95981062-1cb50380-0dec-11eb-833b-1ab6636a5c67.png"> <h3>Updating policy to existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 08 05 AM" src="https://user-images.githubusercontent.com/57655/95981078-1f175d80-0dec-11eb-91d5-7ffd976da48e.png"> </details> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…lastic#82026) * Enhance page load duration metrics and helper tooltips
…#81842) (elastic#82042) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…ic#81952) (elastic#82022) Fixes elastic#81950 by not assuming the summary is present in a bucket with partial check info
…lastic#82054) * Mimics metrics permissions for alert mgmt in logs feature * Updates logs security functional tests Alert management permissions were added for read and all logs users in this PR, so both of these users now have "Stack Management" appear in the nav. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kerry Gallagher <[email protected]>
…astic#82075) * Add experimental copy to upgrade agent(s) * Adjust copy after review * Fix string * Adjust quotes # Conflicts: # x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/fleet/components/agent_upgrade_modal/index.tsx
… to work around the scalability issue. (elastic#82083) (elastic#82093)
…sion path chart (elastic#82011) (elastic#82108) Fixes a regression that caused data grid cells for feature importance to be empty and clicking on the button to show the decision path chart popover to render the whole page empty.
Fixed links to 404 page. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Bo Andersen <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
myasonik
added
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
Pinging @elastic/kibana-core-ui (Team:Core UI) |
myasonik
added
the
release_note:skip
Contributor
Contributor
Author
|
Things have gone wrong... |
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
@kbn/ui-shared-deps asset size
async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
88 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82311
Not sure why or how it got out of sync in 7.10 after being correct on 7.8, 7.9, and master (as of June 2) but it's correct now again.
This is still correct in master so planning on merging this directly into 7.10 unless someone tells me otherwise.