[Ingest Manager] filter out non-upgradeable agents when user bulk upgrades #80391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neptunian
added
bug
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
neptunian
added
the
release_note:skip
nchaulet
reviewed
Oct 13, 2020
| (agent) => | ||
| !agent.unenrollment_started_at && | ||
| !agent.unenrolled_at && | ||
| isAgentUpgradeable(agent, kibanaVersion) |
Member
There was a problem hiding this comment.
Do you think we can update isAgentUpgradeable to have this logic?
Contributor
Author
There was a problem hiding this comment.
Good idea. For the single agent upgrade handler I will still check it to return a descriptive error message.
Contributor
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Oct 13, 2020
…rades (elastic#80391) * filter out non-upgradeable agents when user bulk upgrades * check for unenrolled or unenrolling agents in isAgentUpgradeable
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Oct 13, 2020
…rades (elastic#80391) * filter out non-upgradeable agents when user bulk upgrades * check for unenrolled or unenrolling agents in isAgentUpgradeable
neptunian
added a commit
that referenced
this pull request
Oct 14, 2020
…rades (#80391) (#80420) * filter out non-upgradeable agents when user bulk upgrades * check for unenrolled or unenrolling agents in isAgentUpgradeable Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80070
When a user uses bulk actions to upgrade agents, it was not filtering out agents that were not upgradeable. This change will filter them out so the action never gets sent to the non-upgradeable agent.