-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Security Solution] Fix Timeline row actions overflow #79861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
patrykkopycinski
merged 6 commits into
elastic:master
from
patrykkopycinski:fix/timeline-actions-overflow
Oct 13, 2020
Merged
[Security Solution] Fix Timeline row actions overflow #79861
patrykkopycinski
merged 6 commits into
elastic:master
from
patrykkopycinski:fix/timeline-actions-overflow
Oct 13, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Test FailuresX-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts alerts "before all" hook in "alerts"Standard OutStack TraceX-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts alerts "after all" hook in "alerts"Standard OutStack TraceX-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/index·ts.alerting api integration security and spaces enabled "after all" hook in "alerting api integration security and spaces enabled"Standard OutStack TraceMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
XavierM
reviewed
Oct 13, 2020
| id === TimelineId.detectionsRulesDetailsPage || | ||
| ((id === TimelineId.active && eventType && ['all', 'signal', 'alert'].includes(eventType)) ?? | ||
| false); | ||
| export const hasAdditionalActions = (id: TimelineId): boolean => |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense!!!
XavierM
approved these changes
Oct 13, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 13, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 13, 2020
patrykkopycinski
added a commit
that referenced
this pull request
Oct 14, 2020
patrykkopycinski
added a commit
that referenced
this pull request
Oct 14, 2020
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:SIEM
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before:

After:
