Skip to content

A11y tests for roles page #79900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 8, 2020
Merged

A11y tests for roles page #79900

merged 6 commits into from
Oct 8, 2020

Conversation

@bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Oct 7, 2020 •
edited
Loading

Meta - #51456
a11y tests for roles page plus
Modifications to users.ts (unskipped tests)

Add these to skip a11y checks on ids in axe analyzer helped to deal with eui bug elastic/eui#2841:

{
              id: 'label',
              selector: '[data-test-subj="comboBoxSearchInput"] *',
            },
            {
              id: 'aria-roles',
              selector: '[data-test-subj="comboBoxSearchInput"] *',
            },
          ],

@bhavyarm bhavyarm self-assigned this Oct 7, 2020
@bhavyarm bhavyarm marked this pull request as ready for review October 7, 2020 21:53
@bhavyarm bhavyarm requested a review from a team as a code owner October 7, 2020 21:53
@bhavyarm bhavyarm requested review from LeeDr and myasonik October 7, 2020 21:53
myasonik
myasonik approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer about the rule skips we had to implement for EUI issues but I think this is the right path forward 👍

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Oct 8, 2020

Thanks @myasonik

jportner
jportner approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM -- added data-test-subj in two files 🙂

LeeDr
LeeDr approved these changes Oct 8, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only code review and Jenkins results

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Oct 8, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 8, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
security 1.0MB 1.0MB +68.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm merged commit ab375e4 into elastic:master Oct 8, 2020
@bhavyarm bhavyarm mentioned this pull request Oct 8, 2020
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Oct 8, 2020
@bhavyarm
A11y tests for roles page (elastic#79900)
322ac12
@bhavyarm bhavyarm mentioned this pull request Oct 8, 2020
Closed
77 tasks
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 9, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 9, 2020

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 12, 2020

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

LeeDr pushed a commit that referenced this pull request Oct 13, 2020
@bhavyarm @kibanamachine
[7.10] A11y tests for roles page (#79900) (#80042)
d0e5ab1 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 13, 2020
@LeeDr
Copy link

LeeDr commented Oct 13, 2020

@bhavyarm I merged your PR to 7.10 branch but you still need to create a 7.x backport

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Oct 19, 2020

Thanks @LeeDr

@bhavyarm bhavyarm mentioned this pull request Jan 18, 2021
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Jan 18, 2021
@bhavyarm
A11y tests for roles page (elastic#79900)
0ff5d01 
# Conflicts:
#	x-pack/test/accessibility/config.ts
bhavyarm added a commit that referenced this pull request Jan 18, 2021
@bhavyarm
A11y tests for roles page (#79900) (#88619)
6eb1fab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@myasonik myasonik myasonik approved these changes

@jportner jportner jportner approved these changes

@LeeDr LeeDr LeeDr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bhavyarm bhavyarm

Labels

Feature:Users/Roles/API Keys Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bhavyarm @kibanamachine @LeeDr @myasonik @jportner