Skip to content

Conversation

@myasonik
Copy link
Contributor

@myasonik myasonik commented Nov 2, 2020

Fixes #82311

Following @kobelb's advice, will backport to 7.10 after this gets approved hopefully fixing this once and for all...

Screen Shot 2020-11-02 at 16 14 14

@myasonik myasonik added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.10.0 labels Nov 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kobelb
Copy link
Contributor

kobelb commented Nov 2, 2020

@elasticmachine merge upstream

Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
dashboard 310.4KB 310.4KB -1.0B
discover 81.0KB 81.0KB -2.0B
visualize 40.0KB 40.0KB -2.0B
total -5.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@myasonik myasonik changed the title fixing nav order... again fixing nav visualize nav order Nov 3, 2020
@myasonik myasonik merged commit c9e57a6 into elastic:7.x Nov 3, 2020
@myasonik myasonik deleted the fix-nav-order branch November 3, 2020 01:36
myasonik pushed a commit to myasonik/kibana that referenced this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants