[Ingest Manager]Fix config renaming conflict with xpack.ingestManager and xpack.ingestManager.agents #80394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger and xpack.ingestManager.fleet are used
nchaulet
added
bug
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
…ger and xpack.ingestManager.fleet are used
nchaulet
force-pushed
the
fix-config-renaming
branch
from
4515185 to
d9dc340
Compare
nchaulet
added
the
release_note:skip
jen-huang
approved these changes
Oct 13, 2020
x-pack/plugins/ingest_manager/server/services/epm/registry/registry_url.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Oct 13, 2020
… and xpack.ingestManager.agents (elastic#80394)
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Oct 13, 2020
… and xpack.ingestManager.agents (elastic#80394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The config for Fleet as been renamed from
xpack.ingestManagertoxpack.fleet.*xpack.ingestManager.fleet.*toxpack.fleet.agent.*The rename rule we are using where not working if both
xpack.ingestManager.*andxpack.ingestManager.fleet.*where used.How to reproduce the bug
Configure both fleet and agents using the old key
ingestManagerIn kibana.dev.yml
It should not use your registry
and you should saw this when kibana start