[Lens] Respect requested sub vis type for xy charts #80297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
approved these changes
Oct 13, 2020
Contributor
wylieconlon
left a comment
wylieconlon
left a comment
There was a problem hiding this comment.
I wasn't sure what problem this was solving at first, but after reading a little closer I found that the problem is reproduced with these steps:
- Switch to datatable
- Drag in 3 non-numeric fields, like dates or strings
- Try to switch to any XY chart other than "stacked bar" and it will remove the entire configuration
Contributor
Author
|
Yep, that's it, thanks @wylieconlon |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 14, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 14, 2020
flash1293
added a commit
that referenced
this pull request
Oct 14, 2020
flash1293
added a commit
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80295
A suggestion request can contain a sub visualiation id (used by the chart switcher). So far the XY chart was not respecting this - this caused full data loss for some switches from other chart types (except for stacked bars, because that's the default and always has a suggestion)