[7.10] [Security Solution][Detections] EQL UX Improvements (#80230) #80376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add loading spinner to EQL Query Bar
This gives the user some indication that the validation is being
performed in the background, and that their query's validity is
currently undefined.
* Preserve whitespace on display of rule queries
This is useful for all rules, but particularly for EQL rules, where
sequences will be multiline.
* Fix tests around query description
This content is now wrapped in a whitespace-preserving element, so these
need to be updated ever so slightly.
* Update cypress assertions around rule queries
* Remove extra space from assertion
* This extra space was removed in the presentation component. I didn't
find an explicit reason why it was there in the first place.
* Use have.value when asserting on form inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.10: