-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[APM] Service map handle timeout with messaging #82083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ogupte
merged 1 commit into
elastic:master
from
ogupte:apm-80629-service-map-timeout-message
Oct 29, 2020
Merged
[APM] Service map handle timeout with messaging #82083
ogupte
merged 1 commit into
elastic:master
from
ogupte:apm-80629-service-map-timeout-message
Oct 29, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to work around the scalability issue.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Oct 29, 2020
Member
sorenlouv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
| | Maximum number of unique transaction combinations sampled for generating service map focused on a specific service. Defaults to `100`. | ||
|
|
||
| | `xpack.apm.serviceMapFingerprintGlobalBucketSize` | ||
| | Maximum number of unique transaction combinations sampled for generating the global service map. Defaults to `100`. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs 👍
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Oct 29, 2020
… to work around the scalability issue. (elastic#82083)
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Oct 29, 2020
… to work around the scalability issue. (elastic#82083)
ogupte
added a commit
that referenced
this pull request
Oct 30, 2020
ogupte
added a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80629, with proper timeout messaging and docs for user to work around the scalability issue.
