-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Discover] Skip the Discover to Visualize functional tests for cloud #80469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stratoula
merged 1 commit into
elastic:master
from
stratoula:skip-discover-visualize-on-cloud
Oct 14, 2020
Merged
[Discover] Skip the Discover to Visualize functional tests for cloud #80469
stratoula
merged 1 commit into
elastic:master
from
stratoula:skip-discover-visualize-on-cloud
Oct 14, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-test-triage (failed-test) |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
approved these changes
Oct 14, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 👍 , thx for the comment giving context, didn't pull and test
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Oct 14, 2020
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Oct 14, 2020
stratoula
added a commit
that referenced
this pull request
Oct 14, 2020
stratoula
added a commit
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
failed-test
A test failure on a tracked branch, potentially flaky-test
Feature:Discover
Discover Application
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//
v7.10.0
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #80246.
I skip these tests for cloud as Discover visualizes a field on the legacy visualizations for OSS and on Lens for Basic+. So these tests are testing the OSS navigation so they should be skipped on cloud as the Basic+ navigation is already tested on the x-pack functional tests.