Skip to content

Conversation

@nchaulet
Copy link
Member

@nchaulet nchaulet commented Oct 8, 2020

Description

When we update the revision of an agent we trigger an updated event that generate a POLICY_CHANGE action that will be distributed to agents.

there is a bug that event is triggered two time instead of one, this PR fix that thanks @scunningham for catching that.

How to reproduce the bug

From a fresh Kibana + ES installation

  • update the default policy (change the name of the system integration for example)
  • than do this search in this DEV tools, you should see 3 actions instead of 2
GET .kibana/_search
{
  "query": {
    "bool": {
      "must": [
        {
          "term": {
            "type": "fleet-agent-actions"
          }
        }
      ]
    }
  }
}

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v7.10 labels Oct 8, 2020
@nchaulet nchaulet requested a review from a team October 8, 2020 20:46
@nchaulet nchaulet self-assigned this Oct 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Oct 8, 2020
@nchaulet
Copy link
Member Author

nchaulet commented Oct 8, 2020

@elasticmachine merge upstream

@jen-huang jen-huang added v7.10.0 and removed v7.10 labels Oct 8, 2020
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit c36a276 into elastic:master Oct 13, 2020
@nchaulet nchaulet deleted the fix-agents-policy-bump-revision branch October 13, 2020 12:24
nchaulet added a commit to nchaulet/kibana that referenced this pull request Oct 13, 2020
nchaulet added a commit to nchaulet/kibana that referenced this pull request Oct 13, 2020
nchaulet added a commit that referenced this pull request Oct 13, 2020
nchaulet added a commit that referenced this pull request Oct 13, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 13, 2020
…otphase-to-formlib

* 'master' of github.com:elastic/kibana: (59 commits)
  [Security Solution][Resolver] Replace copy-to-clipboard with native navigator.clipboard (elastic#80193)
  [Security Solution] Reduce initial bundle size (elastic#78992)
  [Security Solution][Resolver] Fix Resize node box-shadow bug (elastic#80223)
  Move observability content (elastic#79978)
  skip flaky suite (elastic#79389)
  removing kibana_datatable` in favor of `datatable` (elastic#75184)
  [ML] Fixes for anomaly swim lane  (elastic#80299)
  [Lens] Smokescreen lens test unskip (elastic#80190)
  Improved AlertsClient tests structure by splitting a huge alerts_client.tests.ts file into a specific files defined by its responsibility. (elastic#80088)
  [APM] React key warning when opening popover with external resources (elastic#80328)
  [Step 1] use Observables on server search API (elastic#79874)
  Apply back pressure in Task Manager whenever Elasticsearch responds with a 429 (elastic#75666)
  [Lens] Leverage original http request error (elastic#79831)
  [Security Solution][Case] Improve ServiceConnectorCaseParams type (elastic#80109)
  [SECURITY_SOLUTION] Fix query on alert histogram (elastic#80219)
  [DOCS] Update ingest node pipelines doc (elastic#79187)
  [Ingest Manager] Split up OpenAPI spec file  (elastic#80107)
  [SECURITY_SOLUTION][ENDPOINT] Fix label on Trusted App create name field (elastic#80001)
  [Ingest Manager] Fix agent policy bump revision to create only one POLICY_CHANGE action (elastic#80081)
  Grid layout fixes (elastic#80305)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/data_tier_allocation_field.tsx
#	x-pack/plugins/index_lifecycle_management/public/shared_imports.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants