[Ingest Manager] Don't error if editing the same agent_policy #80403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
added
release_note:skip
Contributor
Author
|
@jen-huang (maybe @EricDavisX ) would you mind checking this out locally and using the UI to check? Assuming that works for you and the CI passes, I'd like to get merge this ASAP so we can possibly get it in before the BC is cut tomorrow. I can follow up with tests, but since it's critical I'd really like to get something in the BC. Thanks. |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
skh
approved these changes
Oct 14, 2020
Contributor
skh
left a comment
skh
left a comment
There was a problem hiding this comment.
I can reproduce the error, and verified that this change fixes it. 👍
jfsiii
pushed a commit
that referenced
this pull request
Oct 14, 2020
…0502) ## Summary fixes #80136 Haven't added/updated tests yet but tested the various combinations in the UI and all worked as expected. <details><summary>Screenshots</summary> <h3>Policy listing</h3> <img width="1302" alt="Screen Shot 2020-10-14 at 7 05 19 AM" src="https://user-images.githubusercontent.com/57655/95981056-1c1c6d00-0dec-11eb-9746-5e91043f3d19.png"> <h3>Update existing policy succeeds</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 05 49 AM" src="https://user-images.githubusercontent.com/57655/95981059-1cb50380-0dec-11eb-9e55-7a14b72085f9.png"> <h3>Creating new policy w/existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 06 06 AM" src="https://user-images.githubusercontent.com/57655/95981062-1cb50380-0dec-11eb-833b-1ab6636a5c67.png"> <h3>Updating policy to existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 08 05 AM" src="https://user-images.githubusercontent.com/57655/95981078-1f175d80-0dec-11eb-91d5-7ffd976da48e.png"> </details> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Contributor
|
This needs a backport to 7.x too 🙂 |
jfsiii
pushed a commit
that referenced
this pull request
Oct 15, 2020
…0589) ## Summary fixes #80136 Haven't added/updated tests yet but tested the various combinations in the UI and all worked as expected. <details><summary>Screenshots</summary> <h3>Policy listing</h3> <img width="1302" alt="Screen Shot 2020-10-14 at 7 05 19 AM" src="https://user-images.githubusercontent.com/57655/95981056-1c1c6d00-0dec-11eb-9746-5e91043f3d19.png"> <h3>Update existing policy succeeds</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 05 49 AM" src="https://user-images.githubusercontent.com/57655/95981059-1cb50380-0dec-11eb-9e55-7a14b72085f9.png"> <h3>Creating new policy w/existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 06 06 AM" src="https://user-images.githubusercontent.com/57655/95981062-1cb50380-0dec-11eb-833b-1ab6636a5c67.png"> <h3>Updating policy to existing name fails</h3> <img width="1308" alt="Screen Shot 2020-10-14 at 7 08 05 AM" src="https://user-images.githubusercontent.com/57655/95981078-1f175d80-0dec-11eb-91d5-7ffd976da48e.png"> </details> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #80136
Haven't added/updated tests yet but tested the various combinations in the UI and all worked as expected.
Screenshots
Policy listing
Update existing policy succeeds
Creating new policy w/existing name fails
Updating policy to existing name fails