Skip to content

[ML] DF Analytics results: ensure boolean values in confusion matrix are not capitalized #80350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2020
Merged

[ML] DF Analytics results: ensure boolean values in confusion matrix are not capitalized #80350

merged 1 commit into from
Oct 13, 2020

Conversation

@alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Oct 13, 2020 •
edited
Loading

Summary

Ensures boolean schema values in EuiDataGrid in classification confusion matrix do not get capitalized.

image

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner October 13, 2020 14:21
@alvarezmelissa87 alvarezmelissa87 self-assigned this Oct 13, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 13, 2020

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 13, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ml 11.3MB 11.3MB +936.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895
Copy link
Member

qn895 commented Oct 13, 2020

LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit 59a24c2 into elastic:master Oct 13, 2020
This was referenced Oct 13, 2020
Merged
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Oct 13, 2020
@alvarezmelissa87
ensure boolean values in datagrid are not capitalized (elastic#80350)
f5d907b
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfanalytics-matrix-boolean branch October 13, 2020 17:41
alvarezmelissa87 added a commit that referenced this pull request Oct 13, 2020
@alvarezmelissa87
ensure boolean values in datagrid are not capitalized (#80350) (#80386)
776eac6
alvarezmelissa87 added a commit that referenced this pull request Oct 13, 2020
@alvarezmelissa87
ensure boolean values in datagrid are not capitalized (#80350) (#80387)
b1b4fc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels

Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alvarezmelissa87 @elasticmachine @kibanamachine @qn895 @peteharverson