Merged
Conversation
thompsongl
added
chore
v8.0.0
release_note:skip
chandlerprall
suggested changes
Jun 25, 2019
x-pack/legacy/plugins/beats_management/public/components/tag/tag_badge.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/draggables/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/timeline/properties/helpers.tsx
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
spalger
approved these changes
Jun 25, 2019
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
One little ask, but LGTM from operations
Contributor
💚 Build Succeeded |
4 tasks
Contributor
💚 Build Succeeded |
thompsongl
added a commit
to thompsongl/kibana
that referenced
this pull request
Jun 26, 2019
* eui@12.1.0 * jest regenerator-runtime babel-polyfill * TS Toast -> EuiGlobalToastListToast * EuiBadge * EuiCopy * snapshot updates * simplify toast interface usage * misc review cleanup * remove eui core-js resolution
thompsongl
added a commit
that referenced
this pull request
Jun 26, 2019
* Upgrade EUI to 12.1.0 (#39601) * eui@12.1.0 * jest regenerator-runtime babel-polyfill * TS Toast -> EuiGlobalToastListToast * EuiBadge * EuiCopy * snapshot updates * simplify toast interface usage * misc review cleanup * remove eui core-js resolution * toast interface import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eui@11.3.2⏩eui@12.1.0Breaking change was removal of
core-js, which largely only impacted Jest12.1.0EuiNavDrawerFlyouttitle fromh5todiv(#2040)EuiGlobalToastListinto ARIA live region by addingrole="region"attribute to add NVDA/JAWS support (#2055)magnifyWithMinusandmagnifyWithPlusglyphs toEuiIcon(2056)$euiColorInk(2060)autoFocusprop toEuiTabbedContent(2062)popoutglyph inEuiIconto look more like external link (2064)SuperDatePickerto make the start/end date selection more obvious (#2049)toSentenceCasestring service (#2049)EuiSuperSelect'spopoverClassNameto the popover's panel (#2068)editorItemAlignLeft,editorItemAlignCenter,editorItemRight,editorItemAlignTop,editorItemAlignMiddle,editorItemAlignBottom,editorDistributeHorizontal,editorDistributeVertical,editorPositionTopLeft,editorPositionTopRight,editorPositionBottomRight, andeditorPositionBottomLeftglyphs toEuiIcon(2070)EuiRange(#2072)Bug fixes
EuiCopy'schildren(#2048)EuiInMemoryTableto allow sorting on computed columns (#2044)Toastmember export (#2052)EuiFormControlLayoutandprepend/append(#2057)EuiBadgeandEuiCopy(#2052)12.0.0noreferreralso to links withouttarget="_blank"(#2008)EuiCopyto TypeScript (#2016)magnetglyph toEuiIcon(2010)logoAWSSVG inEuiIconto work better in dark mode (#2036)Bug fixes
EuiFlyoutscrolling in Safari (#2033)EuiCallOutheader icon alignment (#2006)EuiInMemoryTablesort value persistence through lifecycle updates (#2035)EuiColorPickerpositioning and keyboard navigation in certain portal contexts (#2038)Breaking changes
core-js, but a global polyfill likecore-js@3is still required (#1982)