Skip to content

(Accessibility) Fix EuiNavDrawerFlyout using <h5> by replacing with <div>#2040

Merged
PhilippBaranovskiy merged 5 commits intoelastic:masterfrom
PhilippBaranovskiy:2039
Jun 17, 2019
Merged

(Accessibility) Fix EuiNavDrawerFlyout using <h5> by replacing with <div>#2040
PhilippBaranovskiy merged 5 commits intoelastic:masterfrom
PhilippBaranovskiy:2039

Conversation

@PhilippBaranovskiy
Copy link
Contributor

@PhilippBaranovskiy PhilippBaranovskiy commented Jun 13, 2019

Fixes #2039
Associated issue: elastic/kibana#34995

Summary

This PR replaces <h5> with <div> and that's it.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@PhilippBaranovskiy PhilippBaranovskiy changed the title drawer heading fix (Accessibility) Fix EuiNavDrawerFlyout using <h5> by replacing with <div> Jun 13, 2019
@PhilippBaranovskiy PhilippBaranovskiy marked this pull request as ready for review June 13, 2019 13:06
@PhilippBaranovskiy PhilippBaranovskiy self-assigned this Jun 13, 2019
@PhilippBaranovskiy
Copy link
Contributor Author

jenkins, test this

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this out locally and it looks good.

It does make me wonder if we're offering a subpar experience for screenreader users given our lack of proper headings, generally speaking. Then again, we don't have control of content and each app is quite different, so I don't see how we could keep that organized enough to be accessible and useful.

One other thought, @snide should we be labeling the EuiNavDrawer as a main navigation region in Kibana?

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @ryankeairns that more thought should be put into the full accessibility (screen-reader) experience of the nav drawer in association with the application it sits within.

PhilippBaranovskiy and others added 2 commits June 14, 2019 00:28
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@PhilippBaranovskiy PhilippBaranovskiy merged commit 9822150 into elastic:master Jun 17, 2019
@PhilippBaranovskiy PhilippBaranovskiy deleted the 2039 branch June 17, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Accessibility) euiNavDrawerFlyout uses <h5> and breaks the structure heading hierachy

3 participants